From: David Miller <davem@davemloft.net>
To: dvhart@linux.intel.com
Cc: linux-kernel@vger.kernel.org, arjan@linux.intel.com,
alan@linux.intel.com, tomoya.rohm@gmail.com,
jeffrey.t.kirsher@intel.com, paul.gortmaker@windriver.com,
jdmason@kudzu.us, netdev@vger.kernel.org
Subject: Re: [PATCH] pch_gbe: Use a randomly generated MAC instead of failing probe
Date: Sat, 14 Jan 2012 11:56:04 -0800 (PST) [thread overview]
Message-ID: <20120114.115604.2101782124431552110.davem@davemloft.net> (raw)
In-Reply-To: <4F11A533.4040406@linux.intel.com>
From: Darren Hart <dvhart@linux.intel.com>
Date: Sat, 14 Jan 2012 07:54:27 -0800
>> Please correct any hardware that hasn't shipped yet or is alpha/beta
>> hardware in testing, so that we don't need stuff like this.
>
> I saw that the use of random_ether_addr is fairly prevalent, and
> attempted a roughly similar sort of approach to others I had seen. Do
> you consider all of those to be "necessary evils" or are there
> legitimate situations for its use?
>
> In any case, with existing hardware out there that is unusable with the
> current pch_gbe driver, can we consider this workaround for inclusion?
I fear that people are just going to add this random MAC stuff way too
easily, it's a spreading disease.
Ship functional hardware instead.
next prev parent reply other threads:[~2012-01-14 19:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-14 6:44 [PATCH] pch_gbe: Use a randomly generated MAC instead of failing probe Darren Hart
2012-01-14 8:14 ` David Miller
2012-01-14 15:54 ` Darren Hart
2012-01-14 19:56 ` David Miller [this message]
2012-01-14 20:29 ` Joe Perches
2012-01-14 21:46 ` Alan Cox
2012-01-14 22:36 ` Darren Hart
2012-01-16 7:38 ` Tomoya MORINAGA
2012-01-16 12:31 ` Alan Cox
2012-01-16 15:42 ` Darren Hart
2012-01-16 16:07 ` Arjan van de Ven
2012-01-16 16:20 ` David Laight
2012-01-16 16:35 ` Arjan van de Ven
2012-01-16 16:44 ` Mark Brown
2012-01-16 17:02 ` Alan Cox
2012-01-16 21:06 ` Rick Jones
2012-01-16 15:38 ` Darren Hart
2012-01-14 8:15 ` David Miller
2012-01-14 8:18 ` Cong Wang
2012-01-14 15:45 ` Darren Hart
2012-01-16 15:22 ` Nick Bowler
2012-01-16 23:04 ` David Miller
2012-01-16 23:07 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120114.115604.2101782124431552110.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=dvhart@linux.intel.com \
--cc=jdmason@kudzu.us \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tomoya.rohm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).