* [PATCH net] dql: Fix inconsistency between file mode and attr method.
@ 2012-01-14 17:10 Hiroaki SHIMODA
2012-01-14 17:21 ` Eric Dumazet
2012-01-17 15:06 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Hiroaki SHIMODA @ 2012-01-14 17:10 UTC (permalink / raw)
To: davem; +Cc: netdev, therbert
There is no store() method for inflight attribute in the
tx-<n>/byte_queue_limits sysfs directory.
So remove S_IWUSR bit.
Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
---
net/core/net-sysfs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index f3dbd4f..a1727cd 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -929,7 +929,7 @@ static ssize_t bql_show_inflight(struct netdev_queue *queue,
}
static struct netdev_queue_attribute bql_inflight_attribute =
- __ATTR(inflight, S_IRUGO | S_IWUSR, bql_show_inflight, NULL);
+ __ATTR(inflight, S_IRUGO, bql_show_inflight, NULL);
#define BQL_ATTR(NAME, FIELD) \
static ssize_t bql_show_ ## NAME(struct netdev_queue *queue, \
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] dql: Fix inconsistency between file mode and attr method.
2012-01-14 17:10 [PATCH net] dql: Fix inconsistency between file mode and attr method Hiroaki SHIMODA
@ 2012-01-14 17:21 ` Eric Dumazet
2012-01-17 15:06 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2012-01-14 17:21 UTC (permalink / raw)
To: Hiroaki SHIMODA; +Cc: davem, netdev, therbert
Le dimanche 15 janvier 2012 à 02:10 +0900, Hiroaki SHIMODA a écrit :
> There is no store() method for inflight attribute in the
> tx-<n>/byte_queue_limits sysfs directory.
> So remove S_IWUSR bit.
>
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
> ---
> net/core/net-sysfs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
> index f3dbd4f..a1727cd 100644
> --- a/net/core/net-sysfs.c
> +++ b/net/core/net-sysfs.c
> @@ -929,7 +929,7 @@ static ssize_t bql_show_inflight(struct netdev_queue *queue,
> }
>
> static struct netdev_queue_attribute bql_inflight_attribute =
> - __ATTR(inflight, S_IRUGO | S_IWUSR, bql_show_inflight, NULL);
> + __ATTR(inflight, S_IRUGO, bql_show_inflight, NULL);
>
> #define BQL_ATTR(NAME, FIELD) \
> static ssize_t bql_show_ ## NAME(struct netdev_queue *queue, \
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] dql: Fix inconsistency between file mode and attr method.
2012-01-14 17:10 [PATCH net] dql: Fix inconsistency between file mode and attr method Hiroaki SHIMODA
2012-01-14 17:21 ` Eric Dumazet
@ 2012-01-17 15:06 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-01-17 15:06 UTC (permalink / raw)
To: shimoda.hiroaki; +Cc: netdev, therbert
From: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Date: Sun, 15 Jan 2012 02:10:21 +0900
> There is no store() method for inflight attribute in the
> tx-<n>/byte_queue_limits sysfs directory.
> So remove S_IWUSR bit.
>
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Applied, with fixed subject line. It's "bql" not "dql" :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-17 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-14 17:10 [PATCH net] dql: Fix inconsistency between file mode and attr method Hiroaki SHIMODA
2012-01-14 17:21 ` Eric Dumazet
2012-01-17 15:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).