From: David Miller <davem@davemloft.net>
To: dvhart@linux.intel.com
Cc: linux-kernel@vger.kernel.org, arjan@linux.intel.com,
alan@linux.intel.com, tomoya.rohm@gmail.com,
jeffrey.t.kirsher@intel.com, paul.gortmaker@windriver.com,
jdmason@kudzu.us, netdev@vger.kernel.org,
broonie@opensource.wolfsonmicro.com, David.Laight@ACULAB.COM,
joe@perches.com
Subject: Re: [PATCH] pch_gbe: Do not abort probe on bad MAC
Date: Wed, 18 Jan 2012 16:41:45 -0500 (EST) [thread overview]
Message-ID: <20120118.164145.973182321372504360.davem@davemloft.net> (raw)
In-Reply-To: <965df7d0c78e4971faf8464ec3da0bb114e9b5ee.1326743419.git.dvhart@linux.intel.com>
From: Darren Hart <dvhart@linux.intel.com>
Date: Mon, 16 Jan 2012 11:50:19 -0800
> If the MAC is invalid or not implemented, do not abort the probe. Issue
> a warning and prevent bringing the interface up until a MAC is set manually
> (via ifconfig $IFACE hw ether $MAC).
>
> Tested on two platforms, one with a valid MAC, the other without a MAC. The real
> MAC is used if present, the interface fails to come up until the MAC is set on
> the other. They successfully get an IP over DHCP and pass a simple ping and
> login over ssh test.
>
> This is meant to allow the Inforce SYS940X development board:
> http://www.inforcecomputing.com/SYS940X_ECX.html
> (and others suffering from a missing MAC) to work with the mainline kernel.
> Without this patch, the probe will fail and the interface will not be created,
> preventing the user from configuring the MAC manually.
>
> This does not make any attempt to address a missing or invalid MAC for the
> pch_phub driver.
>
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Applied, thanks.
prev parent reply other threads:[~2012-01-18 21:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 19:50 [PATCH] pch_gbe: Do not abort probe on bad MAC Darren Hart
2012-01-18 21:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120118.164145.973182321372504360.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@ACULAB.COM \
--cc=alan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dvhart@linux.intel.com \
--cc=jdmason@kudzu.us \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tomoya.rohm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).