From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Javier Martinez Canillas <javier@dowhile0.org>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [REGRESSION] fix smsc911x build failure due to "net/smsc911x: Check if PHY is in operational mode before software reset"
Date: Wed, 18 Jan 2012 17:36:12 +0000 [thread overview]
Message-ID: <20120118173612.GM1068@n2100.arm.linux.org.uk> (raw)
From: Russell King <rmk+kernel@arm.linux.org.uk>
Commit 6386994e03ebbe (net/smsc911x: Check if PHY is in operational
mode before software reset) causes the following build errors with
ARM Versatile Express:
drivers/net/ethernet/smsc/smsc911x.c: In function 'smsc911x_phy_disable_energy_detect':
drivers/net/ethernet/smsc/smsc911x.c:1329: error: 'MII_LAN83C185_CTRL_STATUS' undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1329: error: (Each undeclared identifier is reported only once
drivers/net/ethernet/smsc/smsc911x.c:1329: error: for each function it appears in.)
drivers/net/ethernet/smsc/smsc911x.c:1340: error: 'MII_LAN83C185_EDPWRDOWN' undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1341: error: 'MII_LAN83C185_ENERGYON' undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c: In function 'smsc911x_phy_enable_energy_detect':
drivers/net/ethernet/smsc/smsc911x.c:1364: error: 'MII_LAN83C185_CTRL_STATUS' undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1372: error: 'MII_LAN83C185_EDPWRDOWN' undeclared (first use in this function)
Adding linux/smscphy.h solves this build error.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
--
drivers/net/ethernet/smsc/smsc911x.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 9d0b8ce..9aeb666 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -54,6 +54,7 @@
#include <linux/swab.h>
#include <linux/phy.h>
#include <linux/smsc911x.h>
+#include <linux/smscphy.h>
#include <linux/device.h>
#include <linux/of.h>
#include <linux/of_device.h>
next reply other threads:[~2012-01-18 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 17:36 Russell King - ARM Linux [this message]
2012-01-18 21:03 ` [REGRESSION] fix smsc911x build failure due to "net/smsc911x: Check if PHY is in operational mode before software reset" David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120118173612.GM1068@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=davem@davemloft.net \
--cc=javier@dowhile0.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).