* [REGRESSION] fix smsc911x build failure due to "net/smsc911x: Check if PHY is in operational mode before software reset"
@ 2012-01-18 17:36 Russell King - ARM Linux
2012-01-18 21:03 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Russell King - ARM Linux @ 2012-01-18 17:36 UTC (permalink / raw)
To: Javier Martinez Canillas, David S. Miller; +Cc: netdev
From: Russell King <rmk+kernel@arm.linux.org.uk>
Commit 6386994e03ebbe (net/smsc911x: Check if PHY is in operational
mode before software reset) causes the following build errors with
ARM Versatile Express:
drivers/net/ethernet/smsc/smsc911x.c: In function 'smsc911x_phy_disable_energy_detect':
drivers/net/ethernet/smsc/smsc911x.c:1329: error: 'MII_LAN83C185_CTRL_STATUS' undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1329: error: (Each undeclared identifier is reported only once
drivers/net/ethernet/smsc/smsc911x.c:1329: error: for each function it appears in.)
drivers/net/ethernet/smsc/smsc911x.c:1340: error: 'MII_LAN83C185_EDPWRDOWN' undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1341: error: 'MII_LAN83C185_ENERGYON' undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c: In function 'smsc911x_phy_enable_energy_detect':
drivers/net/ethernet/smsc/smsc911x.c:1364: error: 'MII_LAN83C185_CTRL_STATUS' undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1372: error: 'MII_LAN83C185_EDPWRDOWN' undeclared (first use in this function)
Adding linux/smscphy.h solves this build error.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
--
drivers/net/ethernet/smsc/smsc911x.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 9d0b8ce..9aeb666 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -54,6 +54,7 @@
#include <linux/swab.h>
#include <linux/phy.h>
#include <linux/smsc911x.h>
+#include <linux/smscphy.h>
#include <linux/device.h>
#include <linux/of.h>
#include <linux/of_device.h>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [REGRESSION] fix smsc911x build failure due to "net/smsc911x: Check if PHY is in operational mode before software reset"
2012-01-18 17:36 [REGRESSION] fix smsc911x build failure due to "net/smsc911x: Check if PHY is in operational mode before software reset" Russell King - ARM Linux
@ 2012-01-18 21:03 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-01-18 21:03 UTC (permalink / raw)
To: linux; +Cc: javier, netdev
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
Date: Wed, 18 Jan 2012 17:36:12 +0000
> From: Russell King <rmk+kernel@arm.linux.org.uk>
>
> Commit 6386994e03ebbe (net/smsc911x: Check if PHY is in operational
> mode before software reset) causes the following build errors with
> ARM Versatile Express:
This was already fixed by me by including smscphy.h in smsc911x.h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-18 21:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-18 17:36 [REGRESSION] fix smsc911x build failure due to "net/smsc911x: Check if PHY is in operational mode before software reset" Russell King - ARM Linux
2012-01-18 21:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).