public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
	John Ronciak <john.ronciak@intel.com>,
	John Stultz <john.stultz@linaro.org>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH net-next V3 0/2] igb: ptp hardware clock
Date: Thu, 19 Jan 2012 10:39:06 +0100	[thread overview]
Message-ID: <20120119093906.GC4420@cherladcori01> (raw)
In-Reply-To: <1325984559.2641.0.camel@jtkirshe-mobl>

On Sat, Jan 07, 2012 at 05:02:39PM -0800, Jeff Kirsher wrote:
> On Sat, 2012-01-07 at 20:38 +0100, Richard Cochran wrote:
> > * ChangeLog
> > ** V3
> >    - Driver compiles even without CONFIG_PTP_1588_CLOCK.
> >    - Timestamping always works, even when PTP code missing or fails.
> > ** V2
> >    - Fixed wrong bit shifting in the 82576 code.
> >    - Explained the timestamp locking with a comment in the code.
> >    - Preserved the comments from the original timecompare
> > implementation.
> >    - Added an additional test within the overflow counter code to fix
> >      a race condition. Details of the problem are given in the commit
> >      message.
...
> Thanks Richard, I will add this series to my queue.

Jeff,

Please hold off with these. I adapted the driver to use
timecounter/cyclecounter as Jacob suggested, and the result is surely
nicer. I will post a V4 after I finish testing it.

Thanks,
Richard




------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired

  reply	other threads:[~2012-01-19  9:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07 19:38 [PATCH net-next V3 0/2] igb: ptp hardware clock Richard Cochran
2012-01-07 19:38 ` [PATCH net-next V3 1/2] igb: add PTP Hardware Clock code Richard Cochran
2012-01-09 17:42   ` Keller, Jacob E
2012-01-10  8:44     ` Richard Cochran
2012-01-10  9:33       ` Richard Cochran
2012-01-11 17:14       ` Keller, Jacob E
2012-01-07 19:38 ` [PATCH net-next V3 2/2] igb: offer a PTP Hardware Clock instead of the timecompare method Richard Cochran
2012-01-08  1:02 ` [PATCH net-next V3 0/2] igb: ptp hardware clock Jeff Kirsher
2012-01-19  9:39   ` Richard Cochran [this message]
2012-01-19  9:56     ` Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120119093906.GC4420@cherladcori01 \
    --to=richardcochran@gmail.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jacob.e.keller@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=john.stultz@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox