* [PATCH RFC] SUNPRC: remove marking service temporary sockets with XPT_CHNGBUF
@ 2012-01-20 12:55 Stanislav Kinsbursky
2012-01-20 21:40 ` Trond Myklebust
[not found] ` <20120120125243.7733.81374.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
0 siblings, 2 replies; 3+ messages in thread
From: Stanislav Kinsbursky @ 2012-01-20 12:55 UTC (permalink / raw)
To: Trond.Myklebust
Cc: linux-nfs, xemul, neilb, netdev, linux-kernel, jbottomley,
bfields, davem, devel
This is a cleanup patch.
Service temporary sockets can be TCP or RDMA only. But XPT_CHNGBUF service
socket flag is checked only for UDP sockets on receive.
Thus (if I don't miss something non-obvious) this bit raising for temporary
sockets can be removed.
Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
---
net/sunrpc/svcsock.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index e8af0c9..2867249 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -1381,8 +1381,6 @@ void svc_sock_update_bufs(struct svc_serv *serv)
spin_lock_bh(&serv->sv_lock);
list_for_each_entry(svsk, &serv->sv_permsocks, sk_xprt.xpt_list)
set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);
- list_for_each_entry(svsk, &serv->sv_tempsocks, sk_xprt.xpt_list)
- set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);
spin_unlock_bh(&serv->sv_lock);
}
EXPORT_SYMBOL_GPL(svc_sock_update_bufs);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH RFC] SUNPRC: remove marking service temporary sockets with XPT_CHNGBUF
2012-01-20 12:55 [PATCH RFC] SUNPRC: remove marking service temporary sockets with XPT_CHNGBUF Stanislav Kinsbursky
@ 2012-01-20 21:40 ` Trond Myklebust
[not found] ` <20120120125243.7733.81374.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
1 sibling, 0 replies; 3+ messages in thread
From: Trond Myklebust @ 2012-01-20 21:40 UTC (permalink / raw)
To: Stanislav Kinsbursky
Cc: linux-nfs, xemul, neilb, netdev, linux-kernel, jbottomley,
bfields, davem, devel
On Fri, 2012-01-20 at 16:55 +0400, Stanislav Kinsbursky wrote:
> This is a cleanup patch.
> Service temporary sockets can be TCP or RDMA only. But XPT_CHNGBUF service
> socket flag is checked only for UDP sockets on receive.
> Thus (if I don't miss something non-obvious) this bit raising for temporary
> sockets can be removed.
>
> Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
>
> ---
> net/sunrpc/svcsock.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
> index e8af0c9..2867249 100644
> --- a/net/sunrpc/svcsock.c
> +++ b/net/sunrpc/svcsock.c
> @@ -1381,8 +1381,6 @@ void svc_sock_update_bufs(struct svc_serv *serv)
> spin_lock_bh(&serv->sv_lock);
> list_for_each_entry(svsk, &serv->sv_permsocks, sk_xprt.xpt_list)
> set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);
> - list_for_each_entry(svsk, &serv->sv_tempsocks, sk_xprt.xpt_list)
> - set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);
> spin_unlock_bh(&serv->sv_lock);
> }
> EXPORT_SYMBOL_GPL(svc_sock_update_bufs);
I'm assuming that Bruce will prefer to carry this, since it is
completely orthogonal to the net namespace patchsets.
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <20120120125243.7733.81374.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>]
* Re: [PATCH RFC] SUNPRC: remove marking service temporary sockets with XPT_CHNGBUF
[not found] ` <20120120125243.7733.81374.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
@ 2012-01-20 21:46 ` J. Bruce Fields
0 siblings, 0 replies; 3+ messages in thread
From: J. Bruce Fields @ 2012-01-20 21:46 UTC (permalink / raw)
To: Stanislav Kinsbursky
Cc: Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA,
linux-nfs-u79uwXL29TY76Z2rM5mHXA, xemul-bzQdu9zFT3WakBO8gow8eQ,
neilb-l3A5Bk7waGM, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
jbottomley-bzQdu9zFT3WakBO8gow8eQ, davem-fT/PcQaiUtIeIZ0/mPfg9Q,
devel-GEFAQzZX7r8dnm+yROfE0A
On Fri, Jan 20, 2012 at 04:55:39PM +0400, Stanislav Kinsbursky wrote:
> This is a cleanup patch.
> Service temporary sockets can be TCP or RDMA only. But XPT_CHNGBUF service
> socket flag is checked only for UDP sockets on receive.
> Thus (if I don't miss something non-obvious) this bit raising for temporary
> sockets can be removed.
Yes, I believe that's correct, it's leftover cleanup from
9660439861aa8dbd5e2b8087f33e20760c2c9afc "svcrpc: take advantage of tcp
autotuning".
I'll ignore the "RFC" marking and apply unless you tell me otherwise....
--b.
>
> Signed-off-by: Stanislav Kinsbursky <skinsbursky-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
>
> ---
> net/sunrpc/svcsock.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
> index e8af0c9..2867249 100644
> --- a/net/sunrpc/svcsock.c
> +++ b/net/sunrpc/svcsock.c
> @@ -1381,8 +1381,6 @@ void svc_sock_update_bufs(struct svc_serv *serv)
> spin_lock_bh(&serv->sv_lock);
> list_for_each_entry(svsk, &serv->sv_permsocks, sk_xprt.xpt_list)
> set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);
> - list_for_each_entry(svsk, &serv->sv_tempsocks, sk_xprt.xpt_list)
> - set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);
> spin_unlock_bh(&serv->sv_lock);
> }
> EXPORT_SYMBOL_GPL(svc_sock_update_bufs);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-20 21:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-20 12:55 [PATCH RFC] SUNPRC: remove marking service temporary sockets with XPT_CHNGBUF Stanislav Kinsbursky
2012-01-20 21:40 ` Trond Myklebust
[not found] ` <20120120125243.7733.81374.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2012-01-20 21:46 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).