From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: standby24x7@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH/RESEND] [trivial] sctp : Fix typo in net/sctp/socket.c
Date: Sun, 22 Jan 2012 14:21:29 -0500 (EST) [thread overview]
Message-ID: <20120122.142129.1690845179274032982.davem@davemloft.net> (raw)
In-Reply-To: <1327109035.1921.1.camel@joe2Laptop>
From: Joe Perches <joe@perches.com>
Date: Fri, 20 Jan 2012 17:23:55 -0800
> On Sat, 2012-01-21 at 10:18 +0900, Masanari Iida wrote:
>> Signed-off-by: Masanari Iida<standby24x7@gmail.com>
>>
>> Correct a typo "sctp_setsocktopt_bindx" to "sctp_setsockopt_bindx"
>> in net/sctp/socket.c
>> ---
>> net/sctp/socket.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
>> index 408ebd0..658483e 100644
>> --- a/net/sctp/socket.c
>> +++ b/net/sctp/socket.c
>> @@ -970,7 +970,7 @@ SCTP_STATIC int sctp_setsockopt_bindx(struct sock* sk,
>> void *addr_buf;
>> struct sctp_af *af;
>>
>> - SCTP_DEBUG_PRINTK("sctp_setsocktopt_bindx: sk %p addrs %p"
>> + SCTP_DEBUG_PRINTK("sctp_setsockopt_bindx: sk %p addrs %p"
>> " addrs_size %d opt %d\n", sk, addrs, addrs_size, op);
>
> Let the compiler do it.
>
> SCTP_DEBUG_PRINTK("%s: sk %p addrs %p addrs_size %d opt %d\n",
> __func__, sk, addrs, addrs_size, op);
Masanari, please integrate Joe's feedback into your patch.
prev parent reply other threads:[~2012-01-22 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 1:18 [PATCH/RESEND] [trivial] sctp : Fix typo in net/sctp/socket.c Masanari Iida
2012-01-21 1:23 ` Joe Perches
2012-01-22 19:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120122.142129.1690845179274032982.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=standby24x7@gmail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).