netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH/RESEND] [trivial] sctp : Fix typo in net/sctp/socket.c
@ 2012-01-21  1:18 Masanari Iida
  2012-01-21  1:23 ` Joe Perches
  0 siblings, 1 reply; 3+ messages in thread
From: Masanari Iida @ 2012-01-21  1:18 UTC (permalink / raw)
  To: netdev, linux-kernel; +Cc: trivial, standby24x7

Signed-off-by: Masanari Iida<standby24x7@gmail.com>

Correct a typo "sctp_setsocktopt_bindx" to "sctp_setsockopt_bindx"
in net/sctp/socket.c
---
 net/sctp/socket.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 408ebd0..658483e 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -970,7 +970,7 @@ SCTP_STATIC int sctp_setsockopt_bindx(struct sock* sk,
 	void *addr_buf;
 	struct sctp_af *af;
 
-	SCTP_DEBUG_PRINTK("sctp_setsocktopt_bindx: sk %p addrs %p"
+	SCTP_DEBUG_PRINTK("sctp_setsockopt_bindx: sk %p addrs %p"
 			  " addrs_size %d opt %d\n", sk, addrs, addrs_size, op);
 
 	if (unlikely(addrs_size <= 0))
-- 
1.7.6.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH/RESEND] [trivial] sctp : Fix typo in net/sctp/socket.c
  2012-01-21  1:18 [PATCH/RESEND] [trivial] sctp : Fix typo in net/sctp/socket.c Masanari Iida
@ 2012-01-21  1:23 ` Joe Perches
  2012-01-22 19:21   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2012-01-21  1:23 UTC (permalink / raw)
  To: Masanari Iida; +Cc: netdev, linux-kernel, trivial

On Sat, 2012-01-21 at 10:18 +0900, Masanari Iida wrote:
> Signed-off-by: Masanari Iida<standby24x7@gmail.com>
> 
> Correct a typo "sctp_setsocktopt_bindx" to "sctp_setsockopt_bindx"
> in net/sctp/socket.c
> ---
>  net/sctp/socket.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index 408ebd0..658483e 100644
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -970,7 +970,7 @@ SCTP_STATIC int sctp_setsockopt_bindx(struct sock* sk,
>  	void *addr_buf;
>  	struct sctp_af *af;
>  
> -	SCTP_DEBUG_PRINTK("sctp_setsocktopt_bindx: sk %p addrs %p"
> +	SCTP_DEBUG_PRINTK("sctp_setsockopt_bindx: sk %p addrs %p"
>  			  " addrs_size %d opt %d\n", sk, addrs, addrs_size, op);

Let the compiler do it.

	SCTP_DEBUG_PRINTK("%s: sk %p addrs %p addrs_size %d opt %d\n",
			  __func__, sk, addrs, addrs_size, op);

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH/RESEND] [trivial] sctp : Fix typo in net/sctp/socket.c
  2012-01-21  1:23 ` Joe Perches
@ 2012-01-22 19:21   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2012-01-22 19:21 UTC (permalink / raw)
  To: joe; +Cc: standby24x7, netdev, linux-kernel, trivial

From: Joe Perches <joe@perches.com>
Date: Fri, 20 Jan 2012 17:23:55 -0800

> On Sat, 2012-01-21 at 10:18 +0900, Masanari Iida wrote:
>> Signed-off-by: Masanari Iida<standby24x7@gmail.com>
>> 
>> Correct a typo "sctp_setsocktopt_bindx" to "sctp_setsockopt_bindx"
>> in net/sctp/socket.c
>> ---
>>  net/sctp/socket.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
>> index 408ebd0..658483e 100644
>> --- a/net/sctp/socket.c
>> +++ b/net/sctp/socket.c
>> @@ -970,7 +970,7 @@ SCTP_STATIC int sctp_setsockopt_bindx(struct sock* sk,
>>  	void *addr_buf;
>>  	struct sctp_af *af;
>>  
>> -	SCTP_DEBUG_PRINTK("sctp_setsocktopt_bindx: sk %p addrs %p"
>> +	SCTP_DEBUG_PRINTK("sctp_setsockopt_bindx: sk %p addrs %p"
>>  			  " addrs_size %d opt %d\n", sk, addrs, addrs_size, op);
> 
> Let the compiler do it.
> 
> 	SCTP_DEBUG_PRINTK("%s: sk %p addrs %p addrs_size %d opt %d\n",
> 			  __func__, sk, addrs, addrs_size, op);

Masanari, please integrate Joe's feedback into your patch.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-22 19:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-21  1:18 [PATCH/RESEND] [trivial] sctp : Fix typo in net/sctp/socket.c Masanari Iida
2012-01-21  1:23 ` Joe Perches
2012-01-22 19:21   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).