* [PATCH 1/3] skge: don't assert carrier until link is up
@ 2012-01-20 0:35 Stephen Hemminger
2012-01-22 19:24 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2012-01-20 0:35 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Skge device would assert carrier (link up) as soon as network device open
was called, rather than waiting until PHY has detected link.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
This should go to -stable since reporting bogus link up can break lots of things.
--- a/drivers/net/ethernet/marvell/skge.c 2012-01-19 09:55:39.231722844 -0800
+++ b/drivers/net/ethernet/marvell/skge.c 2012-01-19 15:08:06.929771000 -0800
@@ -2576,6 +2576,7 @@ static int skge_up(struct net_device *de
}
/* Initialize MAC */
+ netif_carrier_off(dev);
spin_lock_bh(&hw->phy_lock);
if (is_genesis(hw))
genesis_mac_init(hw, port);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-22 19:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-20 0:35 [PATCH 1/3] skge: don't assert carrier until link is up Stephen Hemminger
2012-01-22 19:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).