* ethtool: allow ETHTOOL_GSSET_INFO for users
@ 2012-01-22 10:20 Michał Mirosław
2012-01-23 1:19 ` Ben Hutchings
0 siblings, 1 reply; 5+ messages in thread
From: Michał Mirosław @ 2012-01-22 10:20 UTC (permalink / raw)
To: netdev
Allow ETHTOOL_GSSET_INFO ethtool ioctl() for unprivileged users.
ETHTOOL_GSTRINGS is already allowed, but is unusable without this one.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
net/core/ethtool.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
[against net, but probably suitable for stable, too]
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index 921aa2b..369b418 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -1311,6 +1311,7 @@ int dev_ethtool(struct net *net, struct ifreq *ifr)
case ETHTOOL_GRXCSUM:
case ETHTOOL_GTXCSUM:
case ETHTOOL_GSG:
+ case ETHTOOL_GSSET_INFO:
case ETHTOOL_GSTRINGS:
case ETHTOOL_GTSO:
case ETHTOOL_GPERMADDR:
--
1.7.8.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: ethtool: allow ETHTOOL_GSSET_INFO for users
2012-01-22 10:20 ethtool: allow ETHTOOL_GSSET_INFO for users Michał Mirosław
@ 2012-01-23 1:19 ` Ben Hutchings
2012-01-23 4:41 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Ben Hutchings @ 2012-01-23 1:19 UTC (permalink / raw)
To: Michał Mirosław; +Cc: netdev
On Sun, 2012-01-22 at 11:20 +0100, Michał Mirosław wrote:
> Allow ETHTOOL_GSSET_INFO ethtool ioctl() for unprivileged users.
> ETHTOOL_GSTRINGS is already allowed, but is unusable without this one.
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
We should probably also add:
ETHTOOL_GLINK
ETHTOOL_GRXFHINDIR
ETHTOOL_GCHANNELS
Ben.
> ---
> net/core/ethtool.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> [against net, but probably suitable for stable, too]
>
> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
> index 921aa2b..369b418 100644
> --- a/net/core/ethtool.c
> +++ b/net/core/ethtool.c
> @@ -1311,6 +1311,7 @@ int dev_ethtool(struct net *net, struct ifreq *ifr)
> case ETHTOOL_GRXCSUM:
> case ETHTOOL_GTXCSUM:
> case ETHTOOL_GSG:
> + case ETHTOOL_GSSET_INFO:
> case ETHTOOL_GSTRINGS:
> case ETHTOOL_GTSO:
> case ETHTOOL_GPERMADDR:
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ethtool: allow ETHTOOL_GSSET_INFO for users
2012-01-23 1:19 ` Ben Hutchings
@ 2012-01-23 4:41 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2012-01-23 4:41 UTC (permalink / raw)
To: bhutchings; +Cc: mirq-linux, netdev
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 23 Jan 2012 01:19:17 +0000
> On Sun, 2012-01-22 at 11:20 +0100, Michał Mirosław wrote:
>> Allow ETHTOOL_GSSET_INFO ethtool ioctl() for unprivileged users.
>> ETHTOOL_GSTRINGS is already allowed, but is unusable without this one.
>>
>> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> Acked-by: Ben Hutchings <bhutchings@solarflare.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* ethtool: allow ETHTOOL_GSSET_INFO for users
@ 2012-06-12 23:27 Ben Hutchings
2012-06-13 4:33 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Ben Hutchings @ 2012-06-12 23:27 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Michał Mirosław
Please consider this for stable 3.0.y and 3.2.y:
commit f80400a26a2e8bff541de12834a1134358bb6642
Author: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: Sun Jan 22 00:20:40 2012 +0000
ethtool: allow ETHTOOL_GSSET_INFO for users
Allow ETHTOOL_GSSET_INFO ethtool ioctl() for unprivileged users.
ETHTOOL_GSTRINGS is already allowed, but is unusable without this one.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ethtool: allow ETHTOOL_GSSET_INFO for users
2012-06-12 23:27 Ben Hutchings
@ 2012-06-13 4:33 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2012-06-13 4:33 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, mirq-linux
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 13 Jun 2012 00:27:58 +0100
> Please consider this for stable 3.0.y and 3.2.y:
>
> commit f80400a26a2e8bff541de12834a1134358bb6642
> Author: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> Date: Sun Jan 22 00:20:40 2012 +0000
>
> ethtool: allow ETHTOOL_GSSET_INFO for users
Queued up, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-06-13 4:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-22 10:20 ethtool: allow ETHTOOL_GSSET_INFO for users Michał Mirosław
2012-01-23 1:19 ` Ben Hutchings
2012-01-23 4:41 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-06-12 23:27 Ben Hutchings
2012-06-13 4:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).