From: David Miller <davem@davemloft.net>
To: florian@openwrt.org
Cc: cphealy@gmail.com, ben@decadent.org.uk, buytenh@wantstofly.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] dsa: Add reporting of silicon revision for Marvell 88E6123/88E6161/88E6165 switches.
Date: Mon, 23 Jan 2012 13:59:40 -0500 (EST) [thread overview]
Message-ID: <20120123.135940.341602114077968006.davem@davemloft.net> (raw)
In-Reply-To: <4F1D2CDA.9050107@openwrt.org>
From: Florian Fainelli <florian@openwrt.org>
Date: Mon, 23 Jan 2012 10:48:10 +0100
> On 01/23/12 08:20, Chris Healy wrote:
>> + if ((ret& 0xfff0) == 0x1650)
>> return "Marvell 88E6165";
>> }
>
> What about a switch/case here?
I don't think you can express "(ret& 0xfff0) == 0x1650)" using
a switch statement.
But BTW, the formatting of that expression needs to be cleaned up.
It should be "(ret & 0xfff0) == 0x1650)"
next prev parent reply other threads:[~2012-01-23 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 7:20 [PATCH 1/1] dsa: Add reporting of silicon revision for Marvell 88E6123/88E6161/88E6165 switches Chris Healy
2012-01-23 9:48 ` Florian Fainelli
2012-01-23 18:59 ` David Miller [this message]
2012-01-23 19:35 ` Ben Hutchings
2012-01-23 19:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120123.135940.341602114077968006.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=buytenh@wantstofly.org \
--cc=cphealy@gmail.com \
--cc=florian@openwrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).