From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: mcarlson@broadcom.com, mchan@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH] tg3: fix ipv6 header length computation
Date: Mon, 23 Jan 2012 14:25:50 -0500 (EST) [thread overview]
Message-ID: <20120123.142550.882140949914528850.davem@davemloft.net> (raw)
In-Reply-To: <1327317729.2525.16.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 23 Jan 2012 12:22:09 +0100
> tg3_start_xmit() makes the wrong assumption for TSOV6 that skb->head
> doesnt include any payload data.
>
> if (skb_is_gso_v6(skb))
> hdr_len = skb_headlen(skb) - ETH_HLEN;
>
> This is not true anymore after commit f07d960df3 (tcp: avoid frag
> allocation for small frames)
>
> We should instead use : skb_transport_offset(skb) + tcp_hdrlen(skb)
>
> Its also true for IPv4
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> CC: Matt Carlson <mcarlson@broadcom.com>
> CC: Michael Chan <mchan@broadcom.com>
> ---
> I dont have a compatable hardware (5755_PLUS ?) so please guys test
> this...
I've applied this, if testing finds problems we can fix it up or revert.
prev parent reply other threads:[~2012-01-23 19:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 11:22 [PATCH] tg3: fix ipv6 header length computation Eric Dumazet
2012-01-23 19:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120123.142550.882140949914528850.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).