From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: Remove bogus checks of rt_gateway being zero.
Date: Tue, 24 Jan 2012 18:16:39 -0500 (EST) [thread overview]
Message-ID: <20120124.181639.2228224485434148573.davem@davemloft.net> (raw)
In-Reply-To: <1327446946.14373.2.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 25 Jan 2012 00:15:46 +0100
>> @@ -454,8 +454,6 @@ static netdev_tx_t ipip_tunnel_xmit(struct sk_buff *skb, struct net_device *dev)
>> dev->stats.tx_fifo_errors++;
>> goto tx_error;
>> }
>> - if ((dst = rt->rt_gateway) == 0)
>> - goto tx_error_icmp;
>> }
>>
>> rt = ip_route_output_ports(dev_net(dev), &fl4, NULL,
>
> Hmm...
>
> So dst wont be initialized ?
Grrr, good catch, I'll fix this, thanks Eric.
prev parent reply other threads:[~2012-01-24 23:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 23:09 [PATCH] ipv4: Remove bogus checks of rt_gateway being zero David Miller
2012-01-24 23:15 ` Eric Dumazet
2012-01-24 23:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124.181639.2228224485434148573.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).