From: David Miller <davem@davemloft.net>
To: yoshfuji@linux-ipv6.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] ipv4/ipv6: Prepare for new route gateway semantics.
Date: Thu, 26 Jan 2012 16:29:44 -0500 (EST) [thread overview]
Message-ID: <20120126.162944.519956918126453122.davem@davemloft.net> (raw)
In-Reply-To: <4F21C482.4070707@linux-ipv6.org>
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Fri, 27 Jan 2012 06:24:18 +0900
> Why not use ipv6_addr_any()?
Yep, makes sense:
--------------------
ipv6: Use ipv6_addr_any()
Suggested by YOSHIFUJI Hideaki.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/ipv6/route.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 7d7f306..92be12b 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -125,8 +125,7 @@ static inline const void *choose_neigh_daddr(struct rt6_info *rt, const void *da
{
struct in6_addr *p = &rt->rt6i_gateway;
- if (p->s6_addr32[0] | p->s6_addr32[1] |
- p->s6_addr32[2] | p->s6_addr32[3])
+ if (!ipv6_addr_any(p))
return (const void *) p;
return daddr;
}
--
1.7.7.6
next prev parent reply other threads:[~2012-01-26 21:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 20:55 [PATCH 1/2] ipv4/ipv6: Prepare for new route gateway semantics David Miller
2012-01-26 21:24 ` YOSHIFUJI Hideaki
2012-01-26 21:29 ` David Miller [this message]
2012-01-27 18:59 ` Brent Cook
2012-01-27 21:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120126.162944.519956918126453122.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).