From: David Miller <davem@davemloft.net>
To: steweg@ynet.sk
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch v2, kernel 3.2.1] RTNETLINK adjusting values of min_ifinfo_dump_size
Date: Thu, 26 Jan 2012 16:37:25 -0500 (EST) [thread overview]
Message-ID: <20120126.163725.208323115932061885.davem@davemloft.net> (raw)
In-Reply-To: <3280801.2791327611666778.JavaMail.root@5-MeO-DMT.ynet.sk>
From: Stefan Gula <steweg@ynet.sk>
Date: Thu, 26 Jan 2012 22:01:06 +0100 (CET)
> From: Stefan Gula <steweg@gmail.com>
>
> Setting link parameters on a netdevice changes the value
> of if_nlmsg_size(), therefore it is necessary to recalculate
> min_ifinfo_dump_size.
>
> Signed-off-by: Stefan Gula <steweg@gmail.com>
Applied, but:
> + min_ifinfo_dump_size = max_t(u16, if_nlmsg_size(dev),
> + min_ifinfo_dump_size);
> +
The second line is not properly indented, the first non-space
character should line up with the first column after the
openning parenthesis on the previous line.
I fixed this up, but really this was a lot of tooth pulling to
get you to post this patch correctly. You cannot consume this
much maintainer and reviewer resources in the future.
prev parent reply other threads:[~2012-01-26 21:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 21:01 [patch v2, kernel 3.2.1] RTNETLINK adjusting values of min_ifinfo_dump_size Stefan Gula
2012-01-26 21:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120126.163725.208323115932061885.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steweg@ynet.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).