From: David Miller <davem@davemloft.net>
To: glommer@parallels.com
Cc: netdev@vger.kernel.org, mingo@elte.hu
Subject: Re: [PATCH] net/tcp: Fix tcp memory limits initialization when !CONFIG_SYSCTL
Date: Mon, 30 Jan 2012 12:41:53 -0500 (EST) [thread overview]
Message-ID: <20120130.124153.637018079987753669.davem@davemloft.net> (raw)
In-Reply-To: <1327922417-9191-1-git-send-email-glommer@parallels.com>
From: Glauber Costa <glommer@parallels.com>
Date: Mon, 30 Jan 2012 15:20:17 +0400
> sysctl_tcp_mem() initialization was moved to sysctl_tcp_ipv4.c
> in commit 3dc43e3e4d0b52197d3205214fe8f162f9e0c334, since it
> became a per-ns value.
>
> That code, however, will never run when CONFIG_SYSCTL is
> disabled, leading to bogus values on those fields - causing hung
> TCP sockets.
>
> This patch fixes it by keeping an initialization code in
> tcp_init(). It will be overwritten by the first net namespace
> init if CONFIG_SYSCTL is compiled in, and do the right thing if
> it is compiled out.
>
> It is also named properly as tcp_init_mem(), to properly signal
> its non-sysctl side effect on TCP limits.
>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Glauber Costa <glommer@parallels.com>
> Cc: David S. Miller <davem@davemloft.net>
> Link: http://lkml.kernel.org/r/4F22D05A.8030604@parallels.com
> [ renamed the function, tidied up the changelog a bit ]
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Applied, thanks everyone.
next prev parent reply other threads:[~2012-01-30 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 11:20 [PATCH] net/tcp: Fix tcp memory limits initialization when !CONFIG_SYSCTL Glauber Costa
2012-01-30 17:41 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-27 14:22 [v3.3-rc1 regression] TCP: too many of orphaned sockets Ingo Molnar
2012-01-27 14:35 ` Glauber Costa
2012-01-27 16:27 ` Glauber Costa
2012-01-27 21:28 ` David Miller
2012-01-27 21:28 ` Glauber Costa
2012-01-28 11:50 ` [PATCH] net/tcp: Fix tcp memory limits initialization when !CONFIG_SYSCTL Ingo Molnar
2012-01-30 11:17 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130.124153.637018079987753669.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=glommer@parallels.com \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).