From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org
Subject: Re: [PATCH 4/6] netprio_cgroup: use IS_ENABLED() and family
Date: Wed, 01 Feb 2012 02:07:38 -0500 (EST) [thread overview]
Message-ID: <20120201.020738.1965865410881089752.davem@davemloft.net> (raw)
In-Reply-To: <4F28E48D.3040505-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
From: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Date: Wed, 01 Feb 2012 15:06:53 +0800
> 14:59, David Miller wrote:
>>
>> Do not mix genuine bug fixes and cleanups.
>>
>> Otherwise I cannot apply your bug fixes to the 'net' tree.
>>
>> Seperate things out, submit only pure bug fixes first, then
>> later once those changes propagate you can submit the cleanups.
>>
>
> I did seperate them out, so the first three patches are fixes,
> and others are cleanups. I can resend cleanup patches once
> fixes hit mainline.
Seperate them in different groups, don't submit them as one
collection. And definitely don't submit them all at the
same damn time! You have to wait with the dependent cleanups
until the fixes go in, and subsequently show up in my net-next
tree.
I'm not applying this stuff until you submit it properly, in
two stages.
next prev parent reply other threads:[~2012-02-01 7:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 6:55 [PATCH 1/6] netprio_cgroup: fix an off-by-one bug Li Zefan
2012-02-01 6:55 ` [PATCH 3/6] netprio_cgroup: fix wrong memory access when NETPRIO_CGROUP=m Li Zefan
2012-02-01 6:56 ` [PATCH 4/6] netprio_cgroup: use IS_ENABLED() and family Li Zefan
[not found] ` <4F28E203.10502-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-02-01 6:59 ` David Miller
[not found] ` <20120201.015954.2098592611164231843.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-02-01 7:06 ` Li Zefan
[not found] ` <4F28E48D.3040505-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-02-01 7:07 ` David Miller [this message]
2012-02-01 7:22 ` Li Zefan
[not found] ` <4F28E853.7000104-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-02-01 12:02 ` Neil Horman
[not found] ` <4F28E1D1.900-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-02-01 6:55 ` [PATCH 2/6] netprio_cgroup: don't allocate prio table when a device is registered Li Zefan
2012-02-01 6:56 ` [PATCH 5/6] cls_cgroup: use IS_ENABLED() and family Li Zefan
2012-02-01 6:56 ` [PATCH 6/6] cls_cgroup: remove redundant rcu_read_lock/unlock Li Zefan
[not found] ` <4F28E22A.703-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-02-01 7:07 ` Eric Dumazet
2012-02-01 7:10 ` David Miller
2012-02-01 7:20 ` Li Zefan
[not found] ` <4F28E7A0.6000309-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-02-01 7:23 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201.020738.1965865410881089752.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).