From: David Miller <davem@davemloft.net>
To: ehoover@mines.edu
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Implement IP_UNICAST_IF socket option.
Date: Wed, 01 Feb 2012 14:12:32 -0500 (EST) [thread overview]
Message-ID: <20120201.141232.458020616314562146.davem@davemloft.net> (raw)
In-Reply-To: <1327622268-15602-1-git-send-email-ehoover@mines.edu>
From: "Erich E. Hoover" <ehoover@mines.edu>
Date: Thu, 26 Jan 2012 16:57:48 -0700
> The IP_UNICAST_IF feature is needed by the Wine project. This patch
> implements the feature by setting the outgoing interface in the same
> fashion as that of IP_PKTINFO.
>
> Signed-off-by: Erich E. Hoover <ehoover@mines.edu>
Hmmm, this is not how IP_UNICAST_IF is implemented in other systems.
The passed in argument is always a 32-bit network byte order word, and
it is always interpreted as an interface index only. There are no
provisions for specifying an IPV4 address.
I see no value in exporting a different API than what other systems
use, especially if you are adding this interface exactly for providing
support for WINE applications, so please don't do this thing with
argument sizes and ip_mreqn.
next prev parent reply other threads:[~2012-02-01 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 23:57 [PATCH] Implement IP_UNICAST_IF socket option Erich E. Hoover
2012-01-27 9:01 ` Hagen Paul Pfeifer
2012-01-27 15:30 ` Erich E. Hoover
2012-02-01 19:12 ` David Miller [this message]
2012-02-01 19:32 ` Erich E. Hoover
2012-02-01 19:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201.141232.458020616314562146.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ehoover@mines.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).