netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [Patch v2] net: move ifenslave from Documentation/networking to tools/networking
Date: Wed, 01 Feb 2012 14:45:16 -0500 (EST)	[thread overview]
Message-ID: <20120201.144516.1768998791668325095.davem@davemloft.net> (raw)
In-Reply-To: <1328088205-26211-1-git-send-email-xiyou.wangcong@gmail.com>

From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Wed,  1 Feb 2012 17:23:25 +0800

> V2: fix Documentation/networking/Makefile
> 
> ifenslave is a real tool, and it seems main distros already ship this.
> It is nice to move it to tools/networking/ directory.
> 
> (Note that this patch is generated by 'git diff -C', in case of having
> a large patch. It can be applied with git-apply.)
> 
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

This is terrible.

In the existing location there is all kinds of Makefile
infrastructure, for example "hostprogs-X", to build utility programs,
yet the thing you added under tools has to do everything by hand.

  reply	other threads:[~2012-02-01 19:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-01  9:23 [Patch v2] net: move ifenslave from Documentation/networking to tools/networking Cong Wang
2012-02-01 19:45 ` David Miller [this message]
2012-02-01 20:06 ` Jiri Pirko
2012-02-01 20:11 ` Stephen Hemminger
2012-02-02  9:38   ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120201.144516.1768998791668325095.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).