From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch v2] net: move ifenslave from Documentation/networking to tools/networking Date: Wed, 01 Feb 2012 14:45:16 -0500 (EST) Message-ID: <20120201.144516.1768998791668325095.davem@davemloft.net> References: <1328088205-26211-1-git-send-email-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: xiyou.wangcong@gmail.com Return-path: Received: from shards.monkeyblade.net ([198.137.202.13]:33832 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932205Ab2BATpT (ORCPT ); Wed, 1 Feb 2012 14:45:19 -0500 In-Reply-To: <1328088205-26211-1-git-send-email-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Cong Wang Date: Wed, 1 Feb 2012 17:23:25 +0800 > V2: fix Documentation/networking/Makefile > > ifenslave is a real tool, and it seems main distros already ship this. > It is nice to move it to tools/networking/ directory. > > (Note that this patch is generated by 'git diff -C', in case of having > a large patch. It can be applied with git-apply.) > > Cc: "David S. Miller" > Signed-off-by: WANG Cong This is terrible. In the existing location there is all kinds of Makefile infrastructure, for example "hostprogs-X", to build utility programs, yet the thing you added under tools has to do everything by hand.