From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org, sathya.perla@emulex.com,
subbu.seetharaman@emulex.com, ajit.khaparde@emulex.com
Subject: Re: [PATCH net] ethtool: Null-terminate filename passed to ethtool_ops::flash_device
Date: Wed, 01 Feb 2012 14:47:52 -0500 (EST) [thread overview]
Message-ID: <20120201.144752.544117675701129801.davem@davemloft.net> (raw)
In-Reply-To: <1328124745.2541.12.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 1 Feb 2012 19:32:25 +0000
> The parameters for ETHTOOL_FLASHDEV include a filename, which ought to
> be null-terminated. Currently the only driver that implements
> ethtool_ops::flash_device attempts to add a null terminator if
> necessary, but does it wrongly. Do it in the ethtool core instead.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied, thanks Ben.
prev parent reply other threads:[~2012-02-01 19:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 19:32 [PATCH net] ethtool: Null-terminate filename passed to ethtool_ops::flash_device Ben Hutchings
2012-02-01 19:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201.144752.544117675701129801.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajit.khaparde@emulex.com \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
--cc=subbu.seetharaman@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).