From: David Miller <davem@davemloft.net>
To: weiyj.lk@gmail.com
Cc: haiyangz@microsoft.com, kys@microsoft.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net/hyperv: fix the issue that large packets be dropped by bridge
Date: Wed, 01 Feb 2012 23:07:33 -0500 (EST) [thread overview]
Message-ID: <20120201.230733.583713340649766843.davem@davemloft.net> (raw)
In-Reply-To: <CAPgLHd_Yjdpu5_QLOdQdzEuj=1TsGb20oyDORa+YMcyYjKmo2A@mail.gmail.com>
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Thu, 2 Feb 2012 10:43:50 +0800
> On 02/02/2012 03:28 AM, David Miller wrote:
>> From: Wei Yongjun <weiyj.lk@gmail.com>
>> Date: Mon, 30 Jan 2012 16:12:45 +0800
>>
>>> + /*
>>> + * Make sure we got a valid packet message, now total_data_buflen
>>> + * should be the data packet size plus the trailer padding size
>>> + */
>>> + if (pkt->total_data_buflen < rndis_pkt->data_len) {
>>> + netdev_err(dev->net_dev->ndev, "incoming packet message "
>>> + "buffer overflow detected (got %u, min %u)"
>>> + "...dropping this message!\n",
>>> + pkt->total_data_buflen, rndis_pkt->data_len);
>>> + return;
>>> + }
>> This is inappropriate. Any logging message that is potentially remotely
>> triggerable must at a minimum be rate limited. But to be honest I'd
>> much prefer a statistic counter for this kind of event, rather then
>> a log message.
> Maybe the badly described error message confuse you, this error can not be
> triggered remotely, it is the RNDIS control messages, which is sent
> between the host and the RNDIS device.
>
> Remain this error message may help us to detect the host device driver
> bugs or the netvsc ringbuffer bugs.
>
> So how about to change the error message?
Ok.
next prev parent reply other threads:[~2012-02-02 4:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 2:43 [PATCH] net/hyperv: fix the issue that large packets be dropped by bridge Wei Yongjun
2012-02-02 4:07 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-30 8:12 Wei Yongjun
2012-02-01 19:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201.230733.583713340649766843.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).