From: Jiri Pirko <jpirko@redhat.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch v2] net: move ifenslave from Documentation/networking to tools/networking
Date: Wed, 1 Feb 2012 21:06:01 +0100 [thread overview]
Message-ID: <20120201200600.GA2602@minipsycho> (raw)
In-Reply-To: <1328088205-26211-1-git-send-email-xiyou.wangcong@gmail.com>
How about to just let ifenslave rot on the place it is?
Wed, Feb 01, 2012 at 10:23:25AM CET, xiyou.wangcong@gmail.com wrote:
>V2: fix Documentation/networking/Makefile
>
>ifenslave is a real tool, and it seems main distros already ship this.
>It is nice to move it to tools/networking/ directory.
>
>(Note that this patch is generated by 'git diff -C', in case of having
>a large patch. It can be applied with git-apply.)
>
>Cc: "David S. Miller" <davem@davemloft.net>
>Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
>
>---
> Documentation/networking/Makefile | 11 -----------
> tools/networking/Makefile | 10 ++++++++++
> {Documentation => tools}/networking/ifenslave.c | 0
> 3 files changed, 10 insertions(+), 11 deletions(-)
>
>diff --git a/Documentation/networking/Makefile b/Documentation/networking/Makefile
>index 24c308d..5594972 100644
>--- a/Documentation/networking/Makefile
>+++ b/Documentation/networking/Makefile
>@@ -1,12 +1 @@
>-# kbuild trick to avoid linker error. Can be omitted if a module is built.
>-obj- := dummy.o
>-
>-# List of programs to build
>-hostprogs-y := ifenslave
>-
>-HOSTCFLAGS_ifenslave.o += -I$(objtree)/usr/include
>-
>-# Tell kbuild to always build the programs
>-always := $(hostprogs-y)
>-
> obj-m := timestamping/
>diff --git a/tools/networking/Makefile b/tools/networking/Makefile
>new file mode 100644
>index 0000000..7aec262
>--- /dev/null
>+++ b/tools/networking/Makefile
>@@ -0,0 +1,10 @@
>+
>+CC := $(CROSS_COMPILE)gcc
>+CFLAGS := -Wall -Wstrict-prototypes
>+RM := rm -f
>+
>+all: ifenslave
>+ifenslave: ifenslave.c
>+ $(CC) $(CFLAGS) -o $@ $^
>+clean:
>+ $(RM) ifenslave
>diff --git a/Documentation/networking/ifenslave.c b/tools/networking/ifenslave.c
>similarity index 100%
>rename from Documentation/networking/ifenslave.c
>rename to tools/networking/ifenslave.c
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-02-01 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 9:23 [Patch v2] net: move ifenslave from Documentation/networking to tools/networking Cong Wang
2012-02-01 19:45 ` David Miller
2012-02-01 20:06 ` Jiri Pirko [this message]
2012-02-01 20:11 ` Stephen Hemminger
2012-02-02 9:38 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201200600.GA2602@minipsycho \
--to=jpirko@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).