From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net 4/8] ixgbe: fix namespace issues when FCoE is not enabled
Date: Thu, 02 Feb 2012 14:20:05 -0500 (EST) [thread overview]
Message-ID: <20120202.142005.1066192595268413170.davem@davemloft.net> (raw)
In-Reply-To: <1328185221-8591-5-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 2 Feb 2012 04:20:17 -0800
> Several functions are made external but are not used externally when
> FCoE/DCB is not enabled.
>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Do not crap up the *.c files with ifdefs like this.
Better to export these operations via an ops structure of
some kind, rather than doing stuff like this.
I'm not applying this series if it contains stuff like
this.
next prev parent reply other threads:[~2012-02-02 19:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 12:20 [net 0/8][pull request] Intel Wired LAN Driver Update Jeff Kirsher
2012-02-02 12:20 ` [net 1/8] ixgbe: update copyright to 2012 Jeff Kirsher
2012-02-02 12:20 ` [net 2/8] ixgbe: Add warning when no space left for more MAC filters Jeff Kirsher
2012-02-02 12:20 ` [net 3/8] ixgbe: make ethtool strings table const Jeff Kirsher
2012-02-02 12:20 ` [net 4/8] ixgbe: fix namespace issues when FCoE is not enabled Jeff Kirsher
2012-02-02 19:20 ` David Miller [this message]
2012-02-03 5:46 ` Jeff Kirsher
2012-02-02 12:20 ` [net 5/8] ixgbevf: Fix mailbox interrupt ack bug Jeff Kirsher
2012-02-02 12:20 ` [net 6/8] ixgbevf: Update copyright notices Jeff Kirsher
2012-02-02 12:20 ` [net 7/8] igbvf: change copyright date Jeff Kirsher
2012-02-02 12:20 ` [net 8/8] ixgbe: Fix typo in ixgbe_common.h Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202.142005.1066192595268413170.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).