netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sjur.brandeland@stericsson.com
Cc: netdev@vger.kernel.org, sjurbren@gmail.com
Subject: Re: [PATCH net-next 3/3] caif: Add wakeline status tracking
Date: Thu, 02 Feb 2012 14:30:03 -0500 (EST)	[thread overview]
Message-ID: <20120202.143003.1765087987294454113.davem@davemloft.net> (raw)
In-Reply-To: <1328181565-13781-3-git-send-email-sjur.brandeland@stericsson.com>

From: Sjur Brændeland <sjur.brandeland@stericsson.com>
Date: Thu,  2 Feb 2012 12:19:25 +0100

> Add initial support for tracking of wake-line status so we at any time
> know when we have a timer running and HSI wake-line high.
> 
> The cfhsi_notify_rx, and cfhsi_wakeline_aquired/released are
> dummies for now.
> 
> Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>

Magic unused ifdefs and empty methods for a new feature not even
implemented.

No thanks on both counts.

I'm not applying this.

  reply	other threads:[~2012-02-02 19:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02 11:19 [PATCH net-next 1/3] caif: Fix compile warning Sjur Brændeland
2012-02-02 11:19 ` [PATCH net-next 2/3] caif: Add drop count for caif_net device Sjur Brændeland
2012-02-02 11:19 ` [PATCH net-next 3/3] caif: Add wakeline status tracking Sjur Brændeland
2012-02-02 19:30   ` David Miller [this message]
2012-02-02 19:29 ` [PATCH net-next 1/3] caif: Fix compile warning David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120202.143003.1765087987294454113.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sjur.brandeland@stericsson.com \
    --cc=sjurbren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).