From: David Miller <davem@davemloft.net>
To: sjur.brandeland@stericsson.com
Cc: netdev@vger.kernel.org, sjurbren@gmail.com
Subject: Re: [PATCH net 1/2] caif: Bugfix list_del_rcu race in cfmuxl_ctrlcmd.
Date: Thu, 02 Feb 2012 14:31:02 -0500 (EST) [thread overview]
Message-ID: <20120202.143102.1637418171061567370.davem@davemloft.net> (raw)
In-Reply-To: <1328181663-13853-1-git-send-email-sjur.brandeland@stericsson.com>
From: Sjur Brændeland <sjur.brandeland@stericsson.com>
Date: Thu, 2 Feb 2012 12:21:02 +0100
> Always use cfmuxl_remove_uplayer when removing a up-layer.
> cfmuxl_ctrlcmd() can be called independently and in parallel with
> cfmuxl_remove_uplayer(). The race between them could cause list_del_rcu
> to be called on a node which has been already taken out from the list.
> That lead to a (rare) crash on accessing poisoned node->prev inside
> list_del_rcu.
>
> This fix ensures that deletion are done holding the same lock.
>
> Reported-by: Dmitry Tarnyagin <dmitry.tarnyagin@stericsson.com>
> Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
Applied.
prev parent reply other threads:[~2012-02-02 19:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 11:21 [PATCH net 1/2] caif: Bugfix list_del_rcu race in cfmuxl_ctrlcmd Sjur Brændeland
2012-02-02 11:21 ` [PATCH net 2/2] caif: Bugfix double kfree_skb upon xmit failure Sjur Brændeland
2012-02-02 19:31 ` David Miller
2012-02-02 19:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202.143102.1637418171061567370.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sjur.brandeland@stericsson.com \
--cc=sjurbren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).