From: David Miller <davem@davemloft.net>
To: fabio.estevam@freescale.com
Cc: netdev@vger.kernel.org, kernel@pengutronix.de, shawn.guo@freescale.com
Subject: Re: [PATCH] net: fec: Remove macaddr option
Date: Sat, 04 Feb 2012 16:29:36 -0500 (EST) [thread overview]
Message-ID: <20120204.162936.1988486080455883986.davem@davemloft.net> (raw)
In-Reply-To: <1328289904-22401-1-git-send-email-fabio.estevam@freescale.com>
From: Fabio Estevam <fabio.estevam@freescale.com>
Date: Fri, 3 Feb 2012 15:25:04 -0200
> "macaddr" option allows users to pass the MAC address via kernel command line.
>
> Feedbacks from Alan Cox and David Miller (http://www.spinics.net/lists/linux-usb/msg57821.html )
> mention that this is not a good idea, so remove it.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Whilst we can prevent new additions of such module options, you can't
just go and remove them from existing drivers without potentially
breaking things for people.
In this FEC case, the option was added more than a year ago.
I'm not applying this patch.
next prev parent reply other threads:[~2012-02-04 21:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 17:25 [PATCH] net: fec: Remove macaddr option Fabio Estevam
2012-02-04 21:29 ` David Miller [this message]
2012-02-05 22:18 ` Paul Gortmaker
2012-02-05 22:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120204.162936.1988486080455883986.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=kernel@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).