From: David Miller <davem@davemloft.net>
To: mbarekfiras@gmail.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch: net: bpf_jit_comp: Fixed coding style issues.
Date: Sat, 04 Feb 2012 16:51:22 -0500 (EST) [thread overview]
Message-ID: <20120204.165122.841855829159259361.davem@davemloft.net> (raw)
In-Reply-To: <1328229495-7603-1-git-send-email-mbarekfiras@gmail.com>
From: Mbarek Firas <mbarekfiras@gmail.com>
Date: Fri, 3 Feb 2012 01:38:15 +0100
> - COND_SEL(BPF_S_JMP_JGT_K, X86_JA, X86_JBE);
> - COND_SEL(BPF_S_JMP_JGE_K, X86_JAE, X86_JB);
> - COND_SEL(BPF_S_JMP_JEQ_K, X86_JE, X86_JNE);
> - COND_SEL(BPF_S_JMP_JSET_K,X86_JNE, X86_JE);
> - COND_SEL(BPF_S_JMP_JGT_X, X86_JA, X86_JBE);
> - COND_SEL(BPF_S_JMP_JGE_X, X86_JAE, X86_JB);
> - COND_SEL(BPF_S_JMP_JEQ_X, X86_JE, X86_JNE);
> - COND_SEL(BPF_S_JMP_JSET_X,X86_JNE, X86_JE);
> + COND_SEL(BPF_S_JMP_JGT_K, X86_JA, X86_JBE);
> + COND_SEL(BPF_S_JMP_JGE_K, X86_JAE, X86_JB);
> + COND_SEL(BPF_S_JMP_JEQ_K, X86_JE, X86_JNE);
> + COND_SEL(BPF_S_JMP_JSET_K, X86_JNE, X86_JE);
This is rediculious, it's not fixing anything.
There is no requirement that all the arguments have to line up
to the same column on every line.
I'm not applying this patch.
prev parent reply other threads:[~2012-02-04 21:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 0:38 [PATCH] arch: net: bpf_jit_comp: Fixed coding style issues Mbarek Firas
2012-02-04 21:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120204.165122.841855829159259361.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mbarekfiras@gmail.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).