From: David Miller <davem@davemloft.net>
To: vapier@gentoo.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: move ethtool include to where its used
Date: Sun, 05 Feb 2012 00:24:03 -0500 (EST) [thread overview]
Message-ID: <20120205.002403.528386341681036443.davem@davemloft.net> (raw)
In-Reply-To: <201202042120.14192.vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Sat, 4 Feb 2012 21:20:07 -0500
> On Saturday 04 February 2012 16:23:31 David Miller wrote:
>> From: Mike Frysinger <vapier@gentoo.org>
>> > The linux/mii.h headers has long been standalone for userspace. But a
>> > recent commit added linux/ethtool.h to the include list even when it
>> > isn't used. Since we only need this with __KERNEL__, move the include
>> > down to the right spot. Now userland no longer needs to pull this in.
>>
>> I don't understand what the problem is.
>
> the exported linux/mii.h userspace code doesn't need linux/ethtool.h, thus it
> should not need to include it
So there's not bug, you're just twiddling.
I don't think there should be any rule that just because the stuff
needed by a header is in __KERNEL__ we have to put the include in
there too, if the header in question is userspace clean itself.
It's so damn ugly, and error prone during audits (ie. easy to miss),
to have include directives not at the top of the file.
So I'm really not interested at all in applying patches like this
one, sorry.
prev parent reply other threads:[~2012-02-05 5:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 11:17 [PATCH] net: move ethtool include to where its used Mike Frysinger
2012-02-04 21:23 ` David Miller
2012-02-05 2:20 ` Mike Frysinger
2012-02-05 5:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120205.002403.528386341681036443.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox