* [PATCH net 1/1] via-velocity: S3 resume fix.
@ 2012-02-05 9:12 Francois Romieu
0 siblings, 0 replies; 3+ messages in thread
From: Francois Romieu @ 2012-02-05 9:12 UTC (permalink / raw)
To: netdev; +Cc: David Miller, DavidLv@viatech.com.cn
From: David Lv (DavidLv@viatech.com.cn)
Initially diagnosed on Ubuntu 11.04 with kernel 2.6.38.
velocity_close is not called during a suspend / resume cycle in this
driver and it has no business playing directly with power states.
Signed-off-by: David Lv (DavidLv@viatech.com.cn)
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
---
drivers/net/ethernet/via/via-velocity.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c
index 4128d6b..cb35b14 100644
--- a/drivers/net/ethernet/via/via-velocity.c
+++ b/drivers/net/ethernet/via/via-velocity.c
@@ -2491,9 +2491,6 @@ static int velocity_close(struct net_device *dev)
if (dev->irq != 0)
free_irq(dev->irq, dev);
- /* Power down the chip */
- pci_set_power_state(vptr->pdev, PCI_D3hot);
-
velocity_free_rings(vptr);
vptr->flags &= (~VELOCITY_FLAGS_OPENED);
--
1.7.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH net 1/1] via-velocity: S3 resume fix.
@ 2012-02-05 9:22 Francois Romieu
2012-02-05 22:47 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Francois Romieu @ 2012-02-05 9:22 UTC (permalink / raw)
To: netdev; +Cc: David Miller, David Lv
From: David Lv <DavidLv@viatech.com.cn>
Initially diagnosed on Ubuntu 11.04 with kernel 2.6.38.
velocity_close is not called during a suspend / resume cycle in this
driver and it has no business playing directly with power states.
Signed-off-by: David Lv <DavidLv@viatech.com.cn>
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
---
David L., please don't put anything but a valid email address in
your S-o-b line when you send patches (no parenthesis, plain bracket).
Thanks.
drivers/net/ethernet/via/via-velocity.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c
index 4128d6b..cb35b14 100644
--- a/drivers/net/ethernet/via/via-velocity.c
+++ b/drivers/net/ethernet/via/via-velocity.c
@@ -2491,9 +2491,6 @@ static int velocity_close(struct net_device *dev)
if (dev->irq != 0)
free_irq(dev->irq, dev);
- /* Power down the chip */
- pci_set_power_state(vptr->pdev, PCI_D3hot);
-
velocity_free_rings(vptr);
vptr->flags &= (~VELOCITY_FLAGS_OPENED);
--
1.7.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net 1/1] via-velocity: S3 resume fix.
2012-02-05 9:22 [PATCH net 1/1] via-velocity: S3 resume fix Francois Romieu
@ 2012-02-05 22:47 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2012-02-05 22:47 UTC (permalink / raw)
To: romieu; +Cc: netdev, DavidLv
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Sun, 5 Feb 2012 10:22:26 +0100
> From: David Lv <DavidLv@viatech.com.cn>
>
> Initially diagnosed on Ubuntu 11.04 with kernel 2.6.38.
>
> velocity_close is not called during a suspend / resume cycle in this
> driver and it has no business playing directly with power states.
>
> Signed-off-by: David Lv <DavidLv@viatech.com.cn>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-05 22:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-05 9:22 [PATCH net 1/1] via-velocity: S3 resume fix Francois Romieu
2012-02-05 22:47 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-02-05 9:12 Francois Romieu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).