From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [RFC PATCH V4 08/13] xenbus_client: extend interface to support mapping / unmapping of multi page ring. Date: Mon, 6 Feb 2012 12:21:39 -0500 Message-ID: <20120206172139.GA26583@phenom.dumpdata.com> References: <1328201363-13915-1-git-send-email-wei.liu2@citrix.com> <1328201363-13915-9-git-send-email-wei.liu2@citrix.com> <20120203165516.GA20005@phenom.dumpdata.com> <1328289625.7388.38.camel@leeds.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "netdev@vger.kernel.org" , "xen-devel@lists.xensource.com" , Ian Campbell To: Wei Liu Return-path: Received: from acsinet15.oracle.com ([141.146.126.227]:26195 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754562Ab2BFRY3 (ORCPT ); Mon, 6 Feb 2012 12:24:29 -0500 Content-Disposition: inline In-Reply-To: <1328289625.7388.38.camel@leeds.uk.xensource.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Feb 03, 2012 at 05:20:25PM +0000, Wei Liu wrote: > On Fri, 2012-02-03 at 16:55 +0000, Konrad Rzeszutek Wilk wrote: > > On Thu, Feb 02, 2012 at 04:49:18PM +0000, Wei Liu wrote: > > > > > > > So this does the job but with this patch you introduce a compile bisection > > bug, which is a not good. The way around is that in this patch you also > > introduce temporary scaffolding so that the drivers can build. Something > > as simple as an function that calls the new version, but has the right > > arguments. Then the next patch (the one that actually does change > > the backends, will back that wrapper out). > > > > How about squashing these two patches. The changes in backends are > trivial. One thing I forgot to mention is that since the backends touch different subsystems maintainers tree - you will need to get Acks from all of them on a single patch. That should not be an technical issue - except that some maintainers can take longer to respond - so your whole patchset might be delayed by that.