Re: [PATCH] net: Default UDP and UNIX diag to 'n'.

[Anisse Astier <anisse@astier.eu>]

Hi,

On Sat, 07 Jan 2012 12:13:39 -0800 (PST), David Miller <davem@davemloft.net> wrote :

> 
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
>  net/ipv4/Kconfig |    6 +++++-
>  net/unix/Kconfig |    2 +-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> index 1a8f93b..43e1439 100644
> --- a/net/ipv4/Kconfig
> +++ b/net/ipv4/Kconfig
> @@ -410,8 +410,12 @@ config INET_TCP_DIAG
>  	def_tristate INET_DIAG
>  
>  config INET_UDP_DIAG
> +	tristate "UDP: socket monitoring interface"
>  	depends on INET_DIAG
> -	def_tristate INET_DIAG && IPV6
This broke earlier patch 
b872a2371ffd13e6d83423ef621a707df4c158ac "udp_diag: Make it module when ipv6 is a module",
which brings back the compilation error when compiling linus master (v3.3-rc2+):

net/built-in.o: In function `udp_dump_one':
udp_diag.c:(.text+0x59852): undefined reference to `__udp6_lib_lookup'


> +	default n
> +	---help---
> +	  Support for UDP socket monitoring interface used by the ss tool.
> +	  If unsure, say Y.
>  

Regards,

Anisse