From: David Miller <davem@davemloft.net>
To: sathya.perla@emulex.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH] be2net: event queue re-design
Date: Wed, 08 Feb 2012 20:12:30 -0500 (EST) [thread overview]
Message-ID: <20120208.201230.2012432079493836273.davem@davemloft.net> (raw)
In-Reply-To: <1328699511-2152-1-git-send-email-sathya.perla@emulex.com>
From: Sathya Perla <sathya.perla@emulex.com>
Date: Wed, 8 Feb 2012 16:41:51 +0530
> -#define BE_MAX_EQD 96
> +#define BE_MAX_EQD ((u32)96)
What in the world is this garbage? You either don't need it, or you
need to do it cleanly. And doing it cleanly is adding a "U" postfix
or similar to the constant, not destroying how it looks it with an
ugly cast.
next prev parent reply other threads:[~2012-02-09 1:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 11:11 [net-next PATCH] be2net: event queue re-design Sathya Perla
2012-02-09 1:12 ` David Miller [this message]
2012-02-09 7:03 ` Sathya.Perla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208.201230.2012432079493836273.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).