* [patch] netxen_nic: signedness bug in netxen_md_entry_err_chk()
@ 2012-02-08 9:23 Dan Carpenter
2012-02-09 1:28 ` David Miller
2012-02-09 7:27 ` Rajesh Borundia
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2012-02-08 9:23 UTC (permalink / raw)
To: Sony Chacko; +Cc: Rajesh Borundia, netdev, kernel-janitors
"esize" should be signed because it can be negative here. For example,
when we call it in netxen_parse_md_template(), it could be -1 from the
return value of netxen_md_L2Cache().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
index 0a81228..6f37470 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
@@ -2354,7 +2354,7 @@ netxen_md_rdqueue(struct netxen_adapter *adapter,
*/
static int netxen_md_entry_err_chk(struct netxen_adapter *adapter,
- struct netxen_minidump_entry *entry, u32 esize)
+ struct netxen_minidump_entry *entry, int esize)
{
if (esize < 0) {
entry->hdr.driver_flags |= NX_DUMP_SKIP;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] netxen_nic: signedness bug in netxen_md_entry_err_chk()
2012-02-08 9:23 [patch] netxen_nic: signedness bug in netxen_md_entry_err_chk() Dan Carpenter
@ 2012-02-09 1:28 ` David Miller
2012-02-09 7:27 ` Rajesh Borundia
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-02-09 1:28 UTC (permalink / raw)
To: dan.carpenter; +Cc: sony.chacko, rajesh.borundia, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 8 Feb 2012 12:23:36 +0300
> "esize" should be signed because it can be negative here. For example,
> when we call it in netxen_parse_md_template(), it could be -1 from the
> return value of netxen_md_L2Cache().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [patch] netxen_nic: signedness bug in netxen_md_entry_err_chk()
2012-02-08 9:23 [patch] netxen_nic: signedness bug in netxen_md_entry_err_chk() Dan Carpenter
2012-02-09 1:28 ` David Miller
@ 2012-02-09 7:27 ` Rajesh Borundia
1 sibling, 0 replies; 3+ messages in thread
From: Rajesh Borundia @ 2012-02-09 7:27 UTC (permalink / raw)
To: Dan Carpenter, Sony Chacko; +Cc: netdev, kernel-janitors@vger.kernel.org
Thanks Dan for fixing this.
Rajesh
________________________________________
From: Dan Carpenter [dan.carpenter@oracle.com]
Sent: Wednesday, February 08, 2012 2:53 PM
To: Sony Chacko
Cc: Rajesh Borundia; netdev; kernel-janitors@vger.kernel.org
Subject: [patch] netxen_nic: signedness bug in netxen_md_entry_err_chk()
"esize" should be signed because it can be negative here. For example,
when we call it in netxen_parse_md_template(), it could be -1 from the
return value of netxen_md_L2Cache().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
index 0a81228..6f37470 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
@@ -2354,7 +2354,7 @@ netxen_md_rdqueue(struct netxen_adapter *adapter,
*/
static int netxen_md_entry_err_chk(struct netxen_adapter *adapter,
- struct netxen_minidump_entry *entry, u32 esize)
+ struct netxen_minidump_entry *entry, int esize)
{
if (esize < 0) {
entry->hdr.driver_flags |= NX_DUMP_SKIP;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-09 7:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-08 9:23 [patch] netxen_nic: signedness bug in netxen_md_entry_err_chk() Dan Carpenter
2012-02-09 1:28 ` David Miller
2012-02-09 7:27 ` Rajesh Borundia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).