From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Richard Weinberger <richard@nod.at>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, eric.dumazet@gmail.com,
jengelh@medozas.de, rostedt@goodmis.org
Subject: Re: [PATCH 4/4] Netfilter: xt_LOG: Implement ring buffer support
Date: Wed, 8 Feb 2012 11:29:14 +0100 [thread overview]
Message-ID: <20120208102914.GA32092@1984> (raw)
In-Reply-To: <1328400892-22409-7-git-send-email-richard@nod.at>
On Sun, Feb 05, 2012 at 01:14:52AM +0100, Richard Weinberger wrote:
> This patch introduces NETFILTER_XT_TARGET_LOG_RING.
> It allows logging into various ring buffers which are
> represented as pipe-like files in /proc/net/netfilter/xt_LOG_ring/.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> include/linux/netfilter/xt_LOG.h | 13 +-
> include/net/netfilter/nf_log.h | 1 +
> include/net/netfilter/xt_log_ring.h | 24 +
> net/netfilter/Kconfig | 13 +
> net/netfilter/Makefile | 2 +
> net/netfilter/xt_LOG.c | 921 -----------------------------
> net/netfilter/xt_LOG_core.c | 1108 +++++++++++++++++++++++++++++++++++
> net/netfilter/xt_LOG_ring.c | 430 ++++++++++++++
Can you avoid this rename and splitting LOG into two files? I prefer
having everything into the same file xt_LOG.c.
Apart from that, this looks fine to me.
next prev parent reply other threads:[~2012-02-08 10:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-05 0:14 [PATCH v3] Merge ipt_LOG and ip6t_LOG, add ring bufffer support Richard Weinberger
2012-02-05 0:14 ` [PATCH 1/2] iptables: Merge libip6t_LOG and libipt_LOG into libxt_LOG Richard Weinberger
2012-02-05 0:14 ` [PATCH 1/4] Netfilter: Merge ipt_LOG and ip6_LOG into xt_LOG Richard Weinberger
2012-03-01 11:27 ` Pablo Neira Ayuso
2012-03-01 11:41 ` Richard Weinberger
2012-03-01 21:39 ` Richard Weinberger
2012-03-02 16:49 ` Pablo Neira Ayuso
2012-03-02 16:52 ` Richard Weinberger
2012-03-04 11:12 ` Pablo Neira Ayuso
2012-03-04 11:26 ` Richard Weinberger
2012-03-04 11:32 ` Pablo Neira Ayuso
2012-02-05 0:14 ` [PATCH 2/2] iptables: xt_LOG: Add ring buffer support Richard Weinberger
2012-02-05 0:14 ` [PATCH 2/4] ring_buffer: Export for_each_buffer_cpu() Richard Weinberger
2012-02-05 0:14 ` [PATCH 3/4] xt_log: Make printk() in sb_close() optional Richard Weinberger
2012-02-05 0:14 ` [PATCH 4/4] Netfilter: xt_LOG: Implement ring buffer support Richard Weinberger
2012-02-08 10:29 ` Pablo Neira Ayuso [this message]
2012-02-08 10:40 ` Richard Weinberger
-- strict thread matches above, loose matches on Subject: below --
2012-02-09 21:54 [PATCH v4] Merge ipt_LOG and ip6t_LOG, add ring bufffer support Richard Weinberger
2012-02-09 21:54 ` [PATCH 4/4] Netfilter: xt_LOG: Implement ring buffer support Richard Weinberger
2012-02-10 22:10 [PATCH v5] Merge ipt_LOG and ip6t_LOG, add ring bufffer support Richard Weinberger
2012-02-10 22:10 ` [PATCH 4/4] Netfilter: xt_LOG: Implement ring buffer support Richard Weinberger
2012-02-14 0:11 ` Pablo Neira Ayuso
2012-02-14 0:12 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208102914.GA32092@1984 \
--to=pablo@netfilter.org \
--cc=eric.dumazet@gmail.com \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=richard@nod.at \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).