From: David Miller <davem@davemloft.net>
To: gregory.v.rose@intel.com
Cc: netdev@vger.kernel.org
Subject: Re: [RFC PATCH] rtnetlink: Add filter for VF info dump requests
Date: Thu, 09 Feb 2012 13:49:40 -0500 (EST) [thread overview]
Message-ID: <20120209.134940.176223015646381142.davem@davemloft.net> (raw)
In-Reply-To: <C5551D9AAB213A418B7FD5E4A6F30A0702F874CA@ORSMSX106.amr.corp.intel.com>
From: "Rose, Gregory V" <gregory.v.rose@intel.com>
Date: Thu, 9 Feb 2012 18:45:59 +0000
>> -----Original Message-----
>> From: David Miller [mailto:davem@davemloft.net]
>> Sent: Thursday, February 09, 2012 10:44 AM
>> To: Rose, Gregory V
>> Cc: netdev@vger.kernel.org
>> Subject: Re: [RFC PATCH] rtnetlink: Add filter for VF info dump requests
>>
>> From: "Rose, Gregory V" <gregory.v.rose@intel.com>
>> Date: Thu, 9 Feb 2012 16:25:31 +0000
>>
>> > That will change the semantics to the 'ip link show' command quite a
>> bit.
>>
>> I think that's rubbish.
>>
>> You can make "ip link show" do whatever you want, including setting all
>> feature bits in getlink requests, which will preserve existing behavior.
>
> But there will be a change to the command line semantics no? How do
> I communicate which feature bits to set in getlink requests
> otherwise?
Make "ip" internally default to "all" feature bits. I don't really
understand what the consternation is. Right now, that's what happens,
the kernel dumps all the attributes including "VF" stuff.
next prev parent reply other threads:[~2012-02-09 18:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 22:33 [RFC PATCH] rtnetlink: Add filter for VF info dump requests Greg Rose
2012-02-09 1:10 ` David Miller
2012-02-09 16:25 ` Rose, Gregory V
2012-02-09 18:43 ` David Miller
2012-02-09 18:45 ` Rose, Gregory V
2012-02-09 18:49 ` David Miller [this message]
2012-02-09 18:57 ` Rose, Gregory V
2012-02-09 19:01 ` David Miller
2012-02-09 19:06 ` Rose, Gregory V
2012-02-09 19:11 ` Stephen Hemminger
2012-02-09 19:13 ` Rose, Gregory V
2012-02-09 19:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209.134940.176223015646381142.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gregory.v.rose@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).