From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: dan.carpenter@oracle.com, isdn@linux-pingi.de,
lucas.demarchi@profusion.mobi, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] isdn: type bug in isdn_net_header()
Date: Thu, 09 Feb 2012 15:41:38 -0500 (EST) [thread overview]
Message-ID: <20120209.154138.441017381710297517.davem@davemloft.net> (raw)
In-Reply-To: <20120209113410.GB25634@hmsreliant.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Thu, 9 Feb 2012 06:34:11 -0500
> On Thu, Feb 09, 2012 at 01:46:47PM +0300, Dan Carpenter wrote:
>> We use len to store the return value from eth_header(). eth_header()
>> can return -ETH_HLEN (-14). We want to pass this back instead of
>> truncating it to 65522 and returning that.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> ---
>> WARNING: Compile tested only. I don't have this hardware. Please check
>> that I am on the right track.
>>
>> diff --git a/drivers/isdn/i4l/isdn_net.c b/drivers/isdn/i4l/isdn_net.c
>> index 2339d73..802ab87 100644
>> --- a/drivers/isdn/i4l/isdn_net.c
>> +++ b/drivers/isdn/i4l/isdn_net.c
>> @@ -1901,7 +1901,7 @@ static int isdn_net_header(struct sk_buff *skb, struct net_device *dev,
>> {
>> isdn_net_local *lp = netdev_priv(dev);
>> unsigned char *p;
>> - ushort len = 0;
>> + int len = 0;
>>
>> switch (lp->p_encap) {
>> case ISDN_NET_ENCAP_ETHER:
>>
> Looks reasonable
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Applied, thanks.
prev parent reply other threads:[~2012-02-09 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 10:46 [patch] isdn: type bug in isdn_net_header() Dan Carpenter
2012-02-09 11:34 ` Neil Horman
2012-02-09 20:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209.154138.441017381710297517.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=isdn@linux-pingi.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox