From: David Miller <davem@davemloft.net>
To: gregory.v.rose@intel.com
Cc: netdev@vger.kernel.org
Subject: Re: [RFC PATCH] rtnetlink: Fix problem with buffer allocation
Date: Fri, 10 Feb 2012 13:51:51 -0500 (EST) [thread overview]
Message-ID: <20120210.135151.754379087490167636.davem@davemloft.net> (raw)
In-Reply-To: <20120210150518.4002.85507.stgit@gitlad.jf.intel.com>
From: Greg Rose <gregory.v.rose@intel.com>
Date: Fri, 10 Feb 2012 07:05:18 -0800
> +/*
> + * Applications that set NLM_F_EXT have allocated
> + * a 16K or larger buffer.
> + * (Or they should have before using this flag)
> + */
> +#define NLM_F_EXT 0x800 /* Get extended interface info such as VFs */
This is not what I meant.
I meant to add a "netlink attribute" that gets passed in with GETLINK
requests. Which is a u32 set of flag bits, one bit for each extended
feature. So VF would get one bit.
Like "IFLA_EXT_MASK" or similar.
Then rtnl_getlink() would inspect the mask (using nla_get_32()), if
present, and make this control what extended parts of the per-link
dump are provided.
next prev parent reply other threads:[~2012-02-10 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 15:05 [RFC PATCH] rtnetlink: Fix problem with buffer allocation Greg Rose
2012-02-10 18:51 ` David Miller [this message]
2012-02-10 19:07 ` Rose, Gregory V
2012-02-10 19:24 ` David Miller
2012-02-10 19:30 ` Rose, Gregory V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210.135151.754379087490167636.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gregory.v.rose@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).