From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Miller <davem@davemloft.net>
Cc: timo.teras@iki.fi, netdev@vger.kernel.org
Subject: Re: [PATCH 0/4] Fix routing metrics
Date: Fri, 10 Feb 2012 09:44:25 +0100 [thread overview]
Message-ID: <20120210084424.GM23142@secunet.com> (raw)
In-Reply-To: <20120210.031211.2297215055759518521.davem@davemloft.net>
On Fri, Feb 10, 2012 at 03:12:11AM -0500, David Miller wrote:
> From: Steffen Klassert <steffen.klassert@secunet.com>
> Date: Fri, 10 Feb 2012 08:51:07 +0100
>
> > On Fri, Feb 10, 2012 at 02:38:15AM -0500, David Miller wrote:
> >> From: Steffen Klassert <steffen.klassert@secunet.com>
> >> >
> >> > I fully agree with you here. But we check for the genid just in
> >> > rt_init_metrics() which is invoked only on route cache entry
> >> > creation. There is no check when the metrics are accessed,
> >> > because the metrics on the inetpeer are valid on every access.
> >>
> >> Every routing cache entry we will use after the flush will be
> >> a newly created one! All the old ones will be stop being used.
> >
> > Yes, I know that. All inetpeer metrics are updated once with the
> > first new routing cache entry that binds that inetpeer to the route.
>
> And after a routing cache flush, that will be all routing cache
> entries every used after that point.
Yes, the genid check happens once for every new routing cache entry
we recreate. After that, we'll find maching routes in the cache
and we don't do that check.
>
> So since this happens, you don't need to check the inetpeer at every
> metric access. The fact that all routing cache entries get recreated
> will do it for you.
So if rt_init_metrics() is not the right place to check for genid
changes, where would you suggest to do it?
next prev parent reply other threads:[~2012-02-10 8:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 10:11 [PATCH 0/4] Fix routing metrics Steffen Klassert
2012-02-02 10:12 ` [PATCH 1/4] inetpeer: Allocate the peer metrics dynamically Steffen Klassert
2012-02-02 10:12 ` [PATCH 2/4] net: Unlink the inetpeer metrics from dst_entry Steffen Klassert
2012-02-02 10:13 ` [PATCH 3/4] inetpeer: protect the inetpeerpeer metrics with rcu Steffen Klassert
2012-02-02 10:14 ` [PATCH 4/4] route: Invalidate the peer metrics along with the routing cache Steffen Klassert
2012-02-06 20:29 ` [PATCH 0/4] Fix routing metrics David Miller
2012-02-08 7:30 ` Steffen Klassert
2012-02-08 20:18 ` David Miller
2012-02-09 12:44 ` Steffen Klassert
2012-02-09 18:40 ` David Miller
2012-02-10 6:50 ` Steffen Klassert
2012-02-10 7:38 ` David Miller
2012-02-10 7:51 ` Steffen Klassert
2012-02-10 8:12 ` David Miller
2012-02-10 8:44 ` Steffen Klassert [this message]
2012-02-10 18:25 ` David Miller
2012-02-21 6:19 ` Steffen Klassert
2012-02-21 6:36 ` David Miller
2012-02-21 8:18 ` Steffen Klassert
2012-02-21 19:24 ` David Miller
2012-02-24 9:08 ` Steffen Klassert
2012-02-24 9:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210084424.GM23142@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).