* [PATCH] sfc: mtd: Use MTD_FAIL_ADDR_UNKNOWN instead of 0xffffffff
@ 2012-02-12 9:13 Shmulik Ladkani
2012-02-13 5:51 ` David Miller
2012-02-13 16:15 ` Ben Hutchings
0 siblings, 2 replies; 5+ messages in thread
From: Shmulik Ladkani @ 2012-02-12 9:13 UTC (permalink / raw)
To: Ben Hutchings, linux-net-drivers, linux-mtd
Cc: netdev, Artem Bityutskiy, shmulik.ladkani
From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
As of bb0eb217, MTD_FAIL_ADDR_UNKNOWN should be used to indicate mtd
erase failure not specific to any particular block.
Use MTD_FAIL_ADDR_UNKNOWN instead of 0xffffffff when setting
'erase->fail_addr' in 'efx_mtd_erase()'.
Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
---
diff --git a/drivers/net/ethernet/sfc/mtd.c b/drivers/net/ethernet/sfc/mtd.c
index 6622eca..c44a03e 100644
--- a/drivers/net/ethernet/sfc/mtd.c
+++ b/drivers/net/ethernet/sfc/mtd.c
@@ -193,7 +193,7 @@ static int efx_mtd_erase(struct mtd_info *mtd, struct erase_info *erase)
erase->state = MTD_ERASE_DONE;
} else {
erase->state = MTD_ERASE_FAILED;
- erase->fail_addr = 0xffffffff;
+ erase->fail_addr = MTD_FAIL_ADDR_UNKNOWN;
}
mtd_erase_callback(erase);
return rc;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] sfc: mtd: Use MTD_FAIL_ADDR_UNKNOWN instead of 0xffffffff
2012-02-12 9:13 [PATCH] sfc: mtd: Use MTD_FAIL_ADDR_UNKNOWN instead of 0xffffffff Shmulik Ladkani
@ 2012-02-13 5:51 ` David Miller
2012-02-13 7:44 ` Artem Bityutskiy
2012-02-13 16:15 ` Ben Hutchings
1 sibling, 1 reply; 5+ messages in thread
From: David Miller @ 2012-02-13 5:51 UTC (permalink / raw)
To: shmulik.ladkani
Cc: bhutchings, linux-net-drivers, linux-mtd, netdev, dedekind1
From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Date: Sun, 12 Feb 2012 11:13:08 +0200
> From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
>
> As of bb0eb217, MTD_FAIL_ADDR_UNKNOWN should be used to indicate mtd
> erase failure not specific to any particular block.
>
> Use MTD_FAIL_ADDR_UNKNOWN instead of 0xffffffff when setting
> 'erase->fail_addr' in 'efx_mtd_erase()'.
>
> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Ben, what would you like me to do with this one?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sfc: mtd: Use MTD_FAIL_ADDR_UNKNOWN instead of 0xffffffff
2012-02-13 5:51 ` David Miller
@ 2012-02-13 7:44 ` Artem Bityutskiy
0 siblings, 0 replies; 5+ messages in thread
From: Artem Bityutskiy @ 2012-02-13 7:44 UTC (permalink / raw)
To: David Miller
Cc: shmulik.ladkani, bhutchings, linux-net-drivers, linux-mtd, netdev
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
On Mon, 2012-02-13 at 00:51 -0500, David Miller wrote:
> From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
> Date: Sun, 12 Feb 2012 11:13:08 +0200
>
> > From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
> >
> > As of bb0eb217, MTD_FAIL_ADDR_UNKNOWN should be used to indicate mtd
> > erase failure not specific to any particular block.
> >
> > Use MTD_FAIL_ADDR_UNKNOWN instead of 0xffffffff when setting
> > 'erase->fail_addr' in 'efx_mtd_erase()'.
> >
> > Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
>
> Ben, what would you like me to do with this one?
Please, do nothing if you can, we'll handle this through the MTD tree,
thanks.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sfc: mtd: Use MTD_FAIL_ADDR_UNKNOWN instead of 0xffffffff
2012-02-12 9:13 [PATCH] sfc: mtd: Use MTD_FAIL_ADDR_UNKNOWN instead of 0xffffffff Shmulik Ladkani
2012-02-13 5:51 ` David Miller
@ 2012-02-13 16:15 ` Ben Hutchings
2012-02-13 16:56 ` Artem Bityutskiy
1 sibling, 1 reply; 5+ messages in thread
From: Ben Hutchings @ 2012-02-13 16:15 UTC (permalink / raw)
To: Shmulik Ladkani
Cc: linux-net-drivers, linux-mtd, netdev, Artem Bityutskiy,
David Miller
On Sun, 2012-02-12 at 11:13 +0200, Shmulik Ladkani wrote:
> From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
>
> As of bb0eb217, MTD_FAIL_ADDR_UNKNOWN should be used to indicate mtd
> erase failure not specific to any particular block.
>
> Use MTD_FAIL_ADDR_UNKNOWN instead of 0xffffffff when setting
> 'erase->fail_addr' in 'efx_mtd_erase()'.
>
> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> diff --git a/drivers/net/ethernet/sfc/mtd.c b/drivers/net/ethernet/sfc/mtd.c
> index 6622eca..c44a03e 100644
> --- a/drivers/net/ethernet/sfc/mtd.c
> +++ b/drivers/net/ethernet/sfc/mtd.c
> @@ -193,7 +193,7 @@ static int efx_mtd_erase(struct mtd_info *mtd, struct erase_info *erase)
> erase->state = MTD_ERASE_DONE;
> } else {
> erase->state = MTD_ERASE_FAILED;
> - erase->fail_addr = 0xffffffff;
> + erase->fail_addr = MTD_FAIL_ADDR_UNKNOWN;
> }
> mtd_erase_callback(erase);
> return rc;
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sfc: mtd: Use MTD_FAIL_ADDR_UNKNOWN instead of 0xffffffff
2012-02-13 16:15 ` Ben Hutchings
@ 2012-02-13 16:56 ` Artem Bityutskiy
0 siblings, 0 replies; 5+ messages in thread
From: Artem Bityutskiy @ 2012-02-13 16:56 UTC (permalink / raw)
To: Ben Hutchings
Cc: Shmulik Ladkani, linux-net-drivers, linux-mtd, netdev,
David Miller
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
On Mon, 2012-02-13 at 16:15 +0000, Ben Hutchings wrote:
> On Sun, 2012-02-12 at 11:13 +0200, Shmulik Ladkani wrote:
> > From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
> >
> > As of bb0eb217, MTD_FAIL_ADDR_UNKNOWN should be used to indicate mtd
> > erase failure not specific to any particular block.
> >
> > Use MTD_FAIL_ADDR_UNKNOWN instead of 0xffffffff when setting
> > 'erase->fail_addr' in 'efx_mtd_erase()'.
> >
> > Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
> Acked-by: Ben Hutchings <bhutchings@solarflare.com>
OK, pushed to l2-mtd.git with this ack, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-02-13 16:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-12 9:13 [PATCH] sfc: mtd: Use MTD_FAIL_ADDR_UNKNOWN instead of 0xffffffff Shmulik Ladkani
2012-02-13 5:51 ` David Miller
2012-02-13 7:44 ` Artem Bityutskiy
2012-02-13 16:15 ` Ben Hutchings
2012-02-13 16:56 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).