From: David Miller <davem@davemloft.net>
To: klassert@mathematik.tu-chemnitz.de
Cc: jdelvare@suse.de, eric.dumazet@gmail.com, fubar@us.ibm.com,
netdev@vger.kernel.org
Subject: Re: bonding with 3c59x driver
Date: Tue, 14 Feb 2012 14:43:35 -0500 (EST) [thread overview]
Message-ID: <20120214.144335.558771219791311889.davem@davemloft.net> (raw)
In-Reply-To: <20120214133418.GJ32155@v3-1054>
From: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
Date: Tue, 14 Feb 2012 14:34:18 +0100
> On Tue, Feb 14, 2012 at 01:50:57PM +0100, Jean Delvare wrote:
>>
>> > We could have a 5 sec timer in case device is a slave.
>> >
>> > diff --git a/drivers/net/ethernet/3com/3c59x.c
>> > b/drivers/net/ethernet/3com/3c59x.c index 1282f04..e463d10 100644
>> > --- a/drivers/net/ethernet/3com/3c59x.c
>> > +++ b/drivers/net/ethernet/3com/3c59x.c
>> > @@ -1841,7 +1841,7 @@ vortex_timer(unsigned long data)
>> > ok = 1;
>> > }
>> >
>> > - if (!netif_carrier_ok(dev))
>> > + if (dev->flags & IFF_SLAVE || !netif_carrier_ok(dev))
>> > next_tick = 5*HZ;
>> >
>> > if (vp->medialock)
>>
>> Yes I think this makes a lot of sense. If you send this upstream you can
>> add:
>>
>> Acked-by: Jean Delvare <jdelvare@suse.de>
>>
>
> I'm fine with this too.
Eric, please submit this formally.
next prev parent reply other threads:[~2012-02-14 19:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 21:53 bonding with 3c59x driver Jean Delvare
2012-02-13 22:13 ` Jay Vosburgh
2012-02-14 10:22 ` Jean Delvare
2012-02-14 10:35 ` Steffen Klassert
2012-02-14 10:44 ` David Laight
2012-02-14 11:06 ` Steffen Klassert
2012-02-14 11:13 ` Eric Dumazet
2012-02-14 12:50 ` Jean Delvare
2012-02-14 13:34 ` Steffen Klassert
2012-02-14 19:43 ` David Miller [this message]
2012-02-14 20:27 ` [PATCH] 3c59x: shorten timer period for slave devices Eric Dumazet
2012-02-14 20:51 ` Dan Williams
2012-02-14 21:02 ` Eric Dumazet
2012-02-14 21:28 ` David Miller
2012-02-14 18:27 ` bonding with 3c59x driver Rick Jones
2012-02-14 19:27 ` Jean Delvare
2012-02-14 21:06 ` Chris Friesen
2012-02-15 9:53 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214.144335.558771219791311889.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=jdelvare@suse.de \
--cc=klassert@mathematik.tu-chemnitz.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).