From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: piergiorgio.beruto@gmail.com, netdev@vger.kernel.org
Subject: Re: Possible bugfix for AF_UNIX, SOCK_SEQPACKET sockets
Date: Wed, 15 Feb 2012 14:55:11 -0500 (EST) [thread overview]
Message-ID: <20120215.145511.1269077904303781879.davem@davemloft.net> (raw)
In-Reply-To: <1329309727.2437.13.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 15 Feb 2012 13:42:07 +0100
> @@ -1824,7 +1824,7 @@ static int unix_dgram_recvmsg(struct kiocb *iocb, struct socket *sock,
> if (UNIXCB(skb).fp)
> siocb->scm->fp = scm_fp_dup(UNIXCB(skb).fp);
> }
> - err = size;
> + err = (flags & MSG_TRUNC) ? skb->len : size;
>
> scm_recv(sock, msg, siocb->scm, flags);
I'm ok with this, but if it is found to break even one userland application
I'm reverting with impunity.
next prev parent reply other threads:[~2012-02-15 19:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 22:05 Possible bugfix for AF_UNIX, SOCK_SEQPACKET sockets Piergiorgio Beruto
2012-02-15 6:25 ` Eric Dumazet
2012-02-15 10:43 ` Piergiorgio Beruto
2012-02-15 12:42 ` Eric Dumazet
2012-02-15 17:36 ` Piergiorgio Beruto
2012-02-15 18:16 ` Eric Dumazet
2012-02-15 19:55 ` David Miller [this message]
2012-02-18 21:23 ` Piergiorgio Beruto
2012-02-22 9:24 ` [PATCH net-next] af_unix: MSG_TRUNC support for dgram sockets Eric Dumazet
2012-02-22 19:50 ` David Miller
2012-12-20 16:50 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215.145511.1269077904303781879.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=piergiorgio.beruto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).