From: Stephen Hemminger <shemminger@vyatta.com>
To: Knut Petersen <Knut_Petersen@t-online.de>
Cc: netdev@vger.kernel.org, dilieto@lineone.net,
Mirko Lindner <mlindner@syskonnect.de>,
Ralph Roesler <rroesler@syskonnect.de>,
arekm@maven.pl, nitro@legroom.net, Andrew Morton <akpm@osdl.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [REGRESSION, PATCH] sky2 WOL fix
Date: Fri, 17 Feb 2012 11:01:47 -0800 [thread overview]
Message-ID: <20120217110147.1c00b31d@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <4F3E9AC1.6060704@t-online.de>
On Fri, 17 Feb 2012 19:21:53 +0100
Knut Petersen <Knut_Petersen@t-online.de> wrote:
> Your commit broke existing support for WOL on a number of boards.
> This is known to you and to bugzilla.kernel org since 2010. A number of
> people complained about that, but nothing happened.
>
> Neither your original commit description nor the description of the
> PXE_LegNat_Sel I found at other places indicate that setting
> PXE_LegNat_Sel could do any harm.
Please lose the attitude. Any support of sky2 is done as a minor side
project by me. People find a problem, I put in one fix, then someone else
complains and another fix goes in. The regressions happen a lot in power management
because the hardware is not well documented in this area and it is a complex
interaction of kernel, BIOS, motherboard, and general shittiness of implementations.
Because of that I am more likely to believe that what the Marvell code does
is more based on experience on other platforms. The out-of-tree Marvell
driver contains bits that are part of the Windows driver.
next prev parent reply other threads:[~2012-02-17 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 8:25 [REGRESSION, PATCH] sky2 WOL fix Knut Petersen
2012-02-15 17:16 ` Stephen Hemminger
2012-02-17 18:21 ` Knut Petersen
2012-02-17 19:01 ` Stephen Hemminger [this message]
2012-02-17 20:13 ` Jared
2012-02-17 21:35 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217110147.1c00b31d@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=Knut_Petersen@t-online.de \
--cc=akpm@osdl.org \
--cc=arekm@maven.pl \
--cc=davem@davemloft.net \
--cc=dilieto@lineone.net \
--cc=mlindner@syskonnect.de \
--cc=netdev@vger.kernel.org \
--cc=nitro@legroom.net \
--cc=rroesler@syskonnect.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).