From: David Miller <davem@davemloft.net>
To: sbhatewara@vmware.com
Cc: nhorman@tuxdriver.com, mmatveev@redhat.com,
pv-drivers@vmware.com, netdev@vger.kernel.org
Subject: Re: [PATCH] vmxnet3: cap copy length at size of skb to prevent dropped frames on tx
Date: Sun, 19 Feb 2012 18:58:52 -0500 (EST) [thread overview]
Message-ID: <20120219.185852.396438198148869233.davem@davemloft.net> (raw)
In-Reply-To: <19987954.351014.1329422822704.JavaMail.root@zimbra-prod-mbox-5.vmware.com>
From: Shreyas Bhatewara <sbhatewara@vmware.com>
Date: Thu, 16 Feb 2012 12:07:02 -0800 (PST)
>
>> Also, since I'm unable to do this, it wuold be great if vmware could
>> follow up
>> this patch with some additional code commentary as to why 54 bytes is
>> an optimal
>> pull length for a virtual NIC driver. The comment that introduced
>> this was
>> vague on that. Thanks!
>
>
> Neil, thanks for the patch. We fixed this bug in local repositories
> recently and I was about to post a patch to LKML. As for the explanation,
> the vNIC is optimized to work with most frequently occurring headers(TCP)
> and hence needs particular number of bytes in first sg. Even in case of
> UDP this pull is cheaper (CPU utilization wise) to do in guest than in
> device emulation.
>
> Signed-off-by: Shreyas N Bhatewara <sbhatewara@vmware.com>
Applied.
prev parent reply other threads:[~2012-02-19 23:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 11:48 [PATCH] vmxnet3: cap copy length at size of skb to prevent dropped frames on tx Neil Horman
2012-02-16 20:07 ` Shreyas Bhatewara
2012-02-19 23:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120219.185852.396438198148869233.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mmatveev@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pv-drivers@vmware.com \
--cc=sbhatewara@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).