From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] netem: fix dequeue
Date: Sun, 19 Feb 2012 19:00:03 -0500 (EST) [thread overview]
Message-ID: <20120219.190003.460010241580144655.davem@davemloft.net> (raw)
In-Reply-To: <1329373705.5646.13.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 16 Feb 2012 07:28:25 +0100
> commit 50612537e9 (netem: fix classful handling) added two errors in
> netem_dequeue()
>
> 1) After checking skb at the head of tfifo queue for time constraints,
> it dequeues tail skb, thus adding unwanted reordering.
>
> 2) qdisc stats are updated twice per packet
> (one when packet dequeued from tfifo, once when delivered)
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
prev parent reply other threads:[~2012-02-20 0:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 6:28 [PATCH] netem: fix dequeue Eric Dumazet
2012-02-20 0:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120219.190003.460010241580144655.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).