From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH] b44: fix section mismatch warnings in b44.c Date: Sun, 19 Feb 2012 23:13:32 +0300 Message-ID: <20120219201332.GF2855@mwanda> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ChQOR20MqfxkMJg9" Cc: Gary Zambrano , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, Nikola Pajkovsky To: Nikola Pajkovsky Return-path: Received: from rcsinet15.oracle.com ([148.87.113.117]:43212 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754492Ab2BSULg (ORCPT ); Sun, 19 Feb 2012 15:11:36 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: --ChQOR20MqfxkMJg9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 19, 2012 at 03:45:54PM +0100, Nikola Pajkovsky wrote: > From: Nikola Pajkovsky >=20 This changelog is not really helpful. Why did you remove an __exit anotation instead changing the callers? Obviously I looked at the code, so I can answer that question, but I shouldn't have to. It should be explained in the changelog. Sometimes I add in information about when the error message was introduced. It might also be nice to mention what the bad effects of this problem are. > Signed-off-by: Nikola Pajkovsky ^^^^^^^^^^^^^^^^^^^^^ You're sending the patch from your redhat address; it's best to sign it with the redhat address as well. regards, dan carpenter --ChQOR20MqfxkMJg9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPQVfrAAoJEOnZkXI/YHqRQdQP/1Ax4keEUEH8SoCr0yC1xeBD 92KNbeVvOOLUz7bBCtA4IkwhWUIAyDtQUF5naIlmQDJW5p+4IhA20pSm88FtxZKh 2QgOtA1B6kGJ2Mg7QsSfwX8p59XBKmoQHk1zmCx0E1Ym7CHowdBLs+GbaQiOkzVx fyB9LDWKNA3K5dm9gcpoV6LNtzkdYjWTbUsWj3NLlMzG3eeTXVITIkX89b+CZHij 7V6Z/Rtibo5So6dn42pd4KUm4UDzHEKUWUAb7DQSNZBhXHTM0maz9m0EqLl/7cIc lzXG8oj0HbGiEFZL8G+bYR2MQh4JdX2jHVQA5G0Kjjvs3+bVUybOLvkXxv/mh6vu iFiKNTDWRMcXgcdgB4aDQMXySqk1ypd4g22Fsvfc78kYoU3yaVgIpaQ0BCEZHpvW DFbSio1yRIi8SLa7NKNthb6wzURFLM15uBGPpQ0zUNEJB76rQiiilFk9Cdmqx5wO qG/5pW7UtgtrFjJwZ+punIqp3YwCcrXsjULDooGBIHbiTTc5R87eeQ8I9N1JnPnO Ii/CfqnoG78eF+6RQmEJCoJF5dxQm+wTpaHP9lkofgLX2Tse6ERQMVxY9pM+1MwU 7XmAKdV5G7Ef0WgkCNrRFEaDWVegVmITZkNJIQC6eNYMZNgxEA9Fu5iqP7I+DdSx ESoTxeCjZTwiaKXo1ZhV =6OOu -----END PGP SIGNATURE----- --ChQOR20MqfxkMJg9--