* [PATCH] cdc_ether/zaurus: Move Harmony 900 from cdc_ether to zaurus
@ 2012-02-20 1:35 Scott Talbert
2012-02-21 0:29 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Scott Talbert @ 2012-02-20 1:35 UTC (permalink / raw)
To: netdev
Hello,
The Logitech Harmony 900 remote control appears to use the pseudo-MDLM
driver, rather than the standard one. This patch simply moves the device
so that it gets picked up by the correct driver.
Signed-off-by: Scott Talbert <talbert@techie.net>
---
drivers/net/usb/cdc_ether.c | 7 +++++++
drivers/net/usb/zaurus.c | 7 +++++++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index c924ea2..13919dd 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -570,6 +570,13 @@ static const struct usb_device_id products [] = {
.driver_info = (unsigned long)&wwan_info,
},
+/* Logitech Harmony 900 - uses the pseudo-MDLM (BLAN) driver */
+{
+ USB_DEVICE_AND_INTERFACE_INFO(0x046d, 0xc11f, USB_CLASS_COMM,
+ USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
+ .driver_info = 0,
+},
+
/*
* WHITELIST!!!
*
diff --git a/drivers/net/usb/zaurus.c b/drivers/net/usb/zaurus.c
index 1a2234c..246b3bb 100644
--- a/drivers/net/usb/zaurus.c
+++ b/drivers/net/usb/zaurus.c
@@ -349,6 +349,13 @@ static const struct usb_device_id products [] = {
ZAURUS_MASTER_INTERFACE,
.driver_info = OLYMPUS_MXL_INFO,
},
+
+/* Logitech Harmony 900 - uses the pseudo-MDLM (BLAN) driver */
+{
+ USB_DEVICE_AND_INTERFACE_INFO(0x046d, 0xc11f, USB_CLASS_COMM,
+ USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
+ .driver_info = (unsigned long) &bogus_mdlm_info,
+},
{ }, // END
};
MODULE_DEVICE_TABLE(usb, products);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] cdc_ether/zaurus: Move Harmony 900 from cdc_ether to zaurus
2012-02-20 1:35 [PATCH] cdc_ether/zaurus: Move Harmony 900 from cdc_ether to zaurus Scott Talbert
@ 2012-02-21 0:29 ` David Miller
2012-02-21 0:50 ` Scott Talbert
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2012-02-21 0:29 UTC (permalink / raw)
To: talbert; +Cc: netdev
From: Scott Talbert <talbert@techie.net>
Date: Sun, 19 Feb 2012 20:35:29 -0500 (EST)
> The Logitech Harmony 900 remote control appears to use the pseudo-MDLM
> driver, rather than the standard one. This patch simply moves the
> device so that it gets picked up by the correct driver.
>
> Signed-off-by: Scott Talbert <talbert@techie.net>
You're not moving anything, you're adding the ID to not one but two
different drivers.
That doesn't make any sense to me, so either this patch is completely
wrong or you need to rewrite your commit message to explain things
better and more accurately.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cdc_ether/zaurus: Move Harmony 900 from cdc_ether to zaurus
2012-02-21 0:29 ` David Miller
@ 2012-02-21 0:50 ` Scott Talbert
2012-02-21 1:22 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Scott Talbert @ 2012-02-21 0:50 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On Mon, 20 Feb 2012, David Miller wrote:
> From: Scott Talbert <talbert@techie.net>
> Date: Sun, 19 Feb 2012 20:35:29 -0500 (EST)
>
>> The Logitech Harmony 900 remote control appears to use the pseudo-MDLM
>> driver, rather than the standard one. This patch simply moves the
>> device so that it gets picked up by the correct driver.
>>
>> Signed-off-by: Scott Talbert <talbert@techie.net>
>
> You're not moving anything, you're adding the ID to not one but two
> different drivers.
>
> That doesn't make any sense to me, so either this patch is completely
> wrong or you need to rewrite your commit message to explain things
> better and more accurately.
Sorry, to clarify...in the current baseline, the Harmony 900 gets picked
up by the cdc_ether driver by this generic line in cdc_ether.c:
USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MDLM,
USB_CDC_PROTO_NONE),
.driver_info = (unsigned long)&wwan_info,
The intent of my patch is to blacklist the Harmony 900 from cdc_ether and
whitelist it in zaurus.
Scott
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cdc_ether/zaurus: Move Harmony 900 from cdc_ether to zaurus
2012-02-21 0:50 ` Scott Talbert
@ 2012-02-21 1:22 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2012-02-21 1:22 UTC (permalink / raw)
To: talbert; +Cc: netdev
From: Scott Talbert <talbert@techie.net>
Date: Mon, 20 Feb 2012 19:50:57 -0500 (EST)
> On Mon, 20 Feb 2012, David Miller wrote:
>
>> From: Scott Talbert <talbert@techie.net>
>> Date: Sun, 19 Feb 2012 20:35:29 -0500 (EST)
>>
>>> The Logitech Harmony 900 remote control appears to use the pseudo-MDLM
>>> driver, rather than the standard one. This patch simply moves the
>>> device so that it gets picked up by the correct driver.
>>>
>>> Signed-off-by: Scott Talbert <talbert@techie.net>
>>
>> You're not moving anything, you're adding the ID to not one but two
>> different drivers.
>>
>> That doesn't make any sense to me, so either this patch is completely
>> wrong or you need to rewrite your commit message to explain things
>> better and more accurately.
>
> Sorry, to clarify...in the current baseline, the Harmony 900 gets
> picked up by the cdc_ether driver by this generic line in cdc_ether.c:
>
> USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MDLM,
> USB_CDC_PROTO_NONE),
> .driver_info = (unsigned long)&wwan_info,
>
> The intent of my patch is to blacklist the Harmony 900 from cdc_ether
> and whitelist it in zaurus.
Please freshly repost your patch with an updated commit message.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-21 1:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-20 1:35 [PATCH] cdc_ether/zaurus: Move Harmony 900 from cdc_ether to zaurus Scott Talbert
2012-02-21 0:29 ` David Miller
2012-02-21 0:50 ` Scott Talbert
2012-02-21 1:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).