From: David Miller <davem@davemloft.net>
To: talbert@techie.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] cdc_ether/zaurus: Move Harmony 900 from cdc_ether to zaurus
Date: Mon, 20 Feb 2012 20:22:55 -0500 (EST) [thread overview]
Message-ID: <20120220.202255.541297654389940326.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LRH.2.02.1202201943040.31081@bear.techie.net>
From: Scott Talbert <talbert@techie.net>
Date: Mon, 20 Feb 2012 19:50:57 -0500 (EST)
> On Mon, 20 Feb 2012, David Miller wrote:
>
>> From: Scott Talbert <talbert@techie.net>
>> Date: Sun, 19 Feb 2012 20:35:29 -0500 (EST)
>>
>>> The Logitech Harmony 900 remote control appears to use the pseudo-MDLM
>>> driver, rather than the standard one. This patch simply moves the
>>> device so that it gets picked up by the correct driver.
>>>
>>> Signed-off-by: Scott Talbert <talbert@techie.net>
>>
>> You're not moving anything, you're adding the ID to not one but two
>> different drivers.
>>
>> That doesn't make any sense to me, so either this patch is completely
>> wrong or you need to rewrite your commit message to explain things
>> better and more accurately.
>
> Sorry, to clarify...in the current baseline, the Harmony 900 gets
> picked up by the cdc_ether driver by this generic line in cdc_ether.c:
>
> USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MDLM,
> USB_CDC_PROTO_NONE),
> .driver_info = (unsigned long)&wwan_info,
>
> The intent of my patch is to blacklist the Harmony 900 from cdc_ether
> and whitelist it in zaurus.
Please freshly repost your patch with an updated commit message.
prev parent reply other threads:[~2012-02-21 1:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 1:35 [PATCH] cdc_ether/zaurus: Move Harmony 900 from cdc_ether to zaurus Scott Talbert
2012-02-21 0:29 ` David Miller
2012-02-21 0:50 ` Scott Talbert
2012-02-21 1:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220.202255.541297654389940326.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=talbert@techie.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).