From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] cdc_ether/zaurus: Move Harmony 900 from cdc_ether to zaurus Date: Mon, 20 Feb 2012 20:22:55 -0500 (EST) Message-ID: <20120220.202255.541297654389940326.davem@davemloft.net> References: <20120220.192915.1058416494686295446.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: talbert@techie.net Return-path: Received: from shards.monkeyblade.net ([198.137.202.13]:51274 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752023Ab2BUBW7 (ORCPT ); Mon, 20 Feb 2012 20:22:59 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Scott Talbert Date: Mon, 20 Feb 2012 19:50:57 -0500 (EST) > On Mon, 20 Feb 2012, David Miller wrote: > >> From: Scott Talbert >> Date: Sun, 19 Feb 2012 20:35:29 -0500 (EST) >> >>> The Logitech Harmony 900 remote control appears to use the pseudo-MDLM >>> driver, rather than the standard one. This patch simply moves the >>> device so that it gets picked up by the correct driver. >>> >>> Signed-off-by: Scott Talbert >> >> You're not moving anything, you're adding the ID to not one but two >> different drivers. >> >> That doesn't make any sense to me, so either this patch is completely >> wrong or you need to rewrite your commit message to explain things >> better and more accurately. > > Sorry, to clarify...in the current baseline, the Harmony 900 gets > picked up by the cdc_ether driver by this generic line in cdc_ether.c: > > USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MDLM, > USB_CDC_PROTO_NONE), > .driver_info = (unsigned long)&wwan_info, > > The intent of my patch is to blacklist the Harmony 900 from cdc_ether > and whitelist it in zaurus. Please freshly repost your patch with an updated commit message.